[master] Update dependencies from dotnet/efcore #20532

dotnet-maestro · 2020-04-03T23:51:17Z

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

Subscription: ccafa991-4408-48df-d45d-08d76e1d3434
Build: 20200406.2
Date Produced: 4/6/2020 10:56 PM
Commit: 8f764c9d37822715dfd36230b002febd0643ebd9
Branch: refs/heads/master
Updates:
- Microsoft.EntityFrameworkCore.Tools -> 5.0.0-preview.4.20206.2
- Microsoft.EntityFrameworkCore.SqlServer -> 5.0.0-preview.4.20206.2
- dotnet-ef -> 5.0.0-preview.4.20206.2
- Microsoft.EntityFrameworkCore -> 5.0.0-preview.4.20206.2
- Microsoft.EntityFrameworkCore.InMemory -> 5.0.0-preview.4.20206.2
- Microsoft.EntityFrameworkCore.Relational -> 5.0.0-preview.4.20206.2
- Microsoft.EntityFrameworkCore.Sqlite -> 5.0.0-preview.4.20206.2

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Microsoft.Extensions.Caching.Abstractions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Caching.Memory -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.Abstractions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.Binder -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.CommandLine -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.EnvironmentVariables -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.FileExtensions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.Ini -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.Json -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.UserSecrets -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration.Xml -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Configuration -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.DependencyInjection.Abstractions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.DependencyInjection -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.FileProviders.Abstractions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.FileProviders.Composite -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.FileProviders.Physical -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.FileSystemGlobbing -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Hosting.Abstractions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Hosting -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Http -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.Abstractions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.Configuration -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.Console -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.Debug -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.EventSource -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.EventLog -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging.TraceSource -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Options.ConfigurationExtensions -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Options.DataAnnotations -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Options -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Primitives -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)
Microsoft.Extensions.Logging -> 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)

…403.6 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20203.6 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20203.6 - dotnet-ef - 5.0.0-preview.4.20203.6 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20203.6 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20203.6 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20203.6 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20203.6

ghost

Auto-approving dependency update.

dotnet-maestro · 2020-04-03T23:51:50Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…403.5 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20203.5 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20203.5 - dotnet-ef - 5.0.0-preview.4.20203.5 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20203.5 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20203.5 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20203.5 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20203.5

…403.8 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20203.8 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20203.8 - dotnet-ef - 5.0.0-preview.4.20203.8 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20203.8 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20203.8 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20203.8 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20203.8

…404.3 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20204.3 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20204.3 - dotnet-ef - 5.0.0-preview.4.20204.3 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20204.3 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20204.3 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20204.3 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20204.3

…404.8 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20204.8 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20204.8 - dotnet-ef - 5.0.0-preview.4.20204.8 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20204.8 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20204.8 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20204.8 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20204.8

davidfowl · 2020-04-05T21:01:49Z

@ajcvickers Did you guys make a breaking change?

System.MissingMethodException: Method not found: 'Microsoft.EntityFrameworkCore.Metadata.Builders.KeyBuilder Microsoft.EntityFrameworkCore.Metadata.Builders.EntityTypeBuilder`1.HasKey(System.Linq.Expressions.Expression`1<System.Func`2<!0,System.Object>>)'.
   at IdentityServer4.EntityFramework.Extensions.ModelBuilderExtensions.<>c__DisplayClass2_0.<ConfigurePersistedGrantContext>b__0(EntityTypeBuilder`1 grant)
   at Microsoft.EntityFrameworkCore.ModelBuilder.Entity[TEntity](Action`1 buildAction)
   at IdentityServer4.EntityFramework.Extensions.ModelBuilderExtensions.ConfigurePersistedGrantContext(ModelBuilder modelBuilder, OperationalStoreOptions storeOptions)
   at Microsoft.AspNetCore.ApiAuthorization.IdentityServer.ApiAuthorizationDbContext`1.OnModelCreating(ModelBuilder builder)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelCustomizer.Customize(ModelBuilder modelBuilder, DbContext context)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.CreateModel(DbContext context, IConventionSetBuilder conventionSetBuilder)
   at Microsoft.EntityFrameworkCore.Infrastructure.ModelSource.GetModel(DbContext context, IConventionSetBuilder conventionSetBuilder)
   at Microsoft.EntityFrameworkCore.Internal.DbContextServices.CreateModel()
   at Microsoft.EntityFrameworkCore.Internal.DbContextServices.get_Model()
   at Microsoft.EntityFrameworkCore.Infrastructure.EntityFrameworkServicesBuilder.<>c.<TryAddCoreServices>b__7_3(IServiceProvider p)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitFactory(FactoryCallSite factoryCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite singletonCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSiteMain(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScopeCache(ServiceCallSite singletonCallSite, RuntimeResolverContext context)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2.VisitCallSite(ServiceCallSite callSite, TArgument argument)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Resolve(ServiceCallSite callSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.GetService(Type serviceType, ServiceProviderEngineScope serviceProviderEngineScope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngineScope.GetService(Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
   at Microsoft.EntityFrameworkCore.DbContext.get_InternalServiceProvider()
   at Microsoft.EntityFrameworkCore.DbContext.Microsoft.EntityFrameworkCore.Infrastructure.IInfrastructure<System.IServiceProvider>.get_Instance()
   at Microsoft.EntityFrameworkCore.Infrastructure.Internal.InfrastructureExtensions.GetService[TService](IInfrastructure`1 accessor)
   at Microsoft.EntityFrameworkCore.Infrastructure.AccessorExtensions.GetService[TService](IInfrastructure`1 accessor)
   at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.CreateContext(Func`1 factory)
   at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.CreateContext(String contextType)
   at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.AddMigration(String name, String outputDir, String contextType, String namespace)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigrationImpl(String name, String outputDir, String contextType, String namespace)
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigration.<>c__DisplayClass0_0.<.ctor>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_0`1.<Execute>b__0()
   at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Method not found: 'Microsoft.EntityFrameworkCore.Metadata.Builders.KeyBuilder Microsoft.EntityFrameworkCore.Metadata.Builders.EntityTypeBuilder`1.HasKey(System.Linq.Expressions.Expression`1<System.Func`2<!0,System.Object>>)'.

ajcvickers · 2020-04-05T21:03:28Z

@davidfowl Yes. @AndriySvyryd?

dotnet-maestro · 2020-04-05T21:05:11Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

davidfowl · 2020-04-05T21:20:29Z

Did it get approval? Seems like it breaks identity server. Did we do analysis to see what other popular packages it breaks in the ecosystem?

dotnet-maestro · 2020-04-05T21:25:20Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

AndriySvyryd · 2020-04-06T02:54:51Z

This is a binary breaking change, the return type changed. Recompiling will fix it.

dotnet-maestro · 2020-04-06T02:57:41Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-04-06T03:09:44Z

Looks as if recompilation isn't enough. The tests that are currently failing are template tests and they're failing while doing EF migrations e.g.

Project new react --auth Individual --use-local-db failed to run EF migrations.
Process exited with code 1\nStdErr: \nStdOut: Using project 'F:\workspace\_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp5.0\TestTemplates\AspNet.reactindividualuld.3vuixrn3o15\AspNet.reactindividualuld.3vuixrn3o15.csproj'.
Using startup project 'F:\workspace\_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp5.0\TestTemplates\AspNet.reactindividualuld.3vuixrn3o15\AspNet.reactindividualuld.3vuixrn3o15.csproj'.
Writing 'F:\workspace\_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp5.0\TestTemplates\AspNet.reactindividualuld.3vuixrn3o15\obj\AspNet.reactindividualuld.3vuixrn3o15.csproj.EntityFrameworkCore.targets'...
dotnet msbuild /target:GetEFProjectMetadata /property:EFProjectMetadataFile=C:\Users\vsagent\AppData\Local\Temp\tmp354A.tmp /verbosity:quiet /nologo F:\workspace\_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp5.0\TestTemplates\AspNet.reactindividualuld.3vuixrn3o15\AspNet.reactindividualuld.3vuixrn3o15.csproj
Writing 'F:\workspace\_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp5.0\TestTemplates\AspNet.reactindividualuld.3vuixrn3o15\obj\AspNet.reactindividualuld.3vuixrn3o15.csproj.EntityFrameworkCore.targets'...
dotnet msbuild /target:GetEFProjectMetadata /property:EFProjectMetadataFile=C:\Users\vsagent\AppData\Local\Temp\tmp48E2.tmp /verbosity:quiet /nologo

dotnet-maestro · 2020-04-06T03:12:48Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: macOS 10.14)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…406.1 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20206.1 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20206.1 - dotnet-ef - 5.0.0-preview.4.20206.1 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20206.1 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20206.1 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20206.1 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20206.1 Dependency coherency updates - Microsoft.Extensions.Caching.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.Memory - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Binder - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.CommandLine - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.EnvironmentVariables - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.FileExtensions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Ini - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Json - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.UserSecrets - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Xml - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Composite - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Physical - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileSystemGlobbing - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Http - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Configuration - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Console - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Debug - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventSource - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventLog - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.TraceSource - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.ConfigurationExtensions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.DataAnnotations - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Primitives - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)

AndriySvyryd · 2020-04-06T20:44:20Z

@dougbu I investigated the templates tests and locally I get this generated by the test:

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.SpaServices.Extensions" Version="5.0.0-dev" />
    <PackageReference Include="Microsoft.AspNetCore.ApiAuthorization.IdentityServer" Version="5.0.0-dev" />
    <PackageReference Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" Version="5.0.0-dev" />
    <PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="5.0.0-dev" />
    <PackageReference Include="Microsoft.AspNetCore.Identity.UI" Version="5.0.0-dev" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="5.0.0-preview.4.20206.1" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="5.0.0-preview.4.20206.1" />
    <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="5.0.0-preview.4.20206.1" />
  </ItemGroup>

The failure is caused by the mismatch of referenced versions. Not sure where these are coming from.

dotnet-maestro · 2020-04-06T20:45:44Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: macOS 10.14)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

AndriySvyryd · 2020-04-06T21:00:24Z

I found that it's generated by https://github.com/dotnet/aspnetcore/blob/3787d7e7f070543cc9368d589a504fa8c4bd4830/src/ProjectTemplates/Web.Spa.ProjectTemplates/Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj
By the way this is the same version mismatch issue that made #19077 fail

dotnet-maestro · 2020-04-06T21:00:51Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…406.2 - Microsoft.EntityFrameworkCore.Tools - 5.0.0-preview.4.20206.2 - Microsoft.EntityFrameworkCore.SqlServer - 5.0.0-preview.4.20206.2 - dotnet-ef - 5.0.0-preview.4.20206.2 - Microsoft.EntityFrameworkCore - 5.0.0-preview.4.20206.2 - Microsoft.EntityFrameworkCore.InMemory - 5.0.0-preview.4.20206.2 - Microsoft.EntityFrameworkCore.Relational - 5.0.0-preview.4.20206.2 - Microsoft.EntityFrameworkCore.Sqlite - 5.0.0-preview.4.20206.2 Dependency coherency updates - Microsoft.Extensions.Caching.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Caching.Memory - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Binder - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.CommandLine - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.EnvironmentVariables - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.FileExtensions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Ini - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Json - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.UserSecrets - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration.Xml - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Configuration - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.DependencyInjection - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Composite - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileProviders.Physical - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.FileSystemGlobbing - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Hosting - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Http - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Abstractions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Configuration - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Console - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.Debug - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventSource - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.EventLog - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging.TraceSource - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.ConfigurationExtensions - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options.DataAnnotations - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Options - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Primitives - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language) - Microsoft.Extensions.Logging - 5.0.0-preview.4.20201.2 (parent: Microsoft.AspNetCore.Razor.Language)

AndriySvyryd · 2020-04-07T00:37:12Z

Disregard my previous 2 comments, the templates are fine. When identity server is rebuilt this will be fixed.

dotnet-maestro · 2020-04-07T00:37:41Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

davidfowl · 2020-04-07T00:42:07Z

How did you fix it? Doesn’t it require a new identity server ?

dotnet-maestro · 2020-04-07T00:42:44Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-04-07T00:44:11Z

What's the expected timing for "When identity server is rebuilt this will be fixed."❔ If it's not nearly-immediate, we should pin EFCore dependencies at their previous versions to cut down on the noise.

@davidfowl I think @AndriySvyryd's comment above answers your earlier question about breaking the ecosystem.

dotnet-maestro · 2020-04-07T00:47:46Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies Unsuccessful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

AndriySvyryd · 2020-04-07T00:55:20Z

What's the expected timing for "When identity server is rebuilt this will be fixed."❔

Filed DuendeArchive/IdentityServer4#4259

If it's not nearly-immediate, we should pin EFCore dependencies at their previous versions to cut down on the noise.

👍

dotnet-maestro · 2020-04-07T00:57:51Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❌ Standard Merge Policies No un-ignored checks.
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-04-07T01:03:24Z

Updated this PR to do nothing except pin the EFCore dependencies.

dougbu · 2020-04-07T01:06:31Z

@AndriySvyryd and @ajcvickers if there's a build between 5.0.0-preview.4.20203.1 and 5.0.0-preview.4.20206.2 that you'd prefer we stick with, please let us know. It's not that hard to run darc locally to update to a specific version.

/fyi @Pilchie

dotnet-maestro · 2020-04-07T01:07:56Z

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

❓ Waiting on checks: aspnetcore-ci, aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: macOS 10.14), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Windows ARM64), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Code check)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dougbu · 2020-04-07T01:08:33Z

@JunTaoLuo if you get a chance to "Squash and merge" this PR, please update the description to describe pinning instead of an actual dependency update.

dotnet-maestro · 2020-04-07T01:12:58Z

Auto-Merge Status

This pull request will be merged because the following merge policies have succeeded.

✔️ Standard Merge Policies Succeeded - Successful checks: aspnetcore-ci, aspnetcore-ci (Build Test: Linux Source Build), aspnetcore-ci (Build Tests: Helix x64), aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64), aspnetcore-ci (Build Test: macOS 10.14), aspnetcore-ci (Build Test: Ubuntu 16.04 x64), aspnetcore-ci (Build Test: Windows Server 2016 x64), aspnetcore-ci (Build Build: Linux Musl ARM64), aspnetcore-ci (Build Build: Linux Musl x64), aspnetcore-ci (Build Build: Linux ARM64), aspnetcore-ci (Build Build: Linux ARM), aspnetcore-ci (Build Build: Windows ARM64), aspnetcore-ci (Build Build: Linux x64), aspnetcore-ci (Build Build: macOS), aspnetcore-ci (Build Build: Windows ARM), aspnetcore-ci (Build Build: Windows x64/x86), aspnetcore-ci (Build Code check)
✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dotnet-maestro bot requested a review from dougbu as a code owner April 3, 2020 23:51

ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Apr 3, 2020

ghost approved these changes Apr 3, 2020

View reviewed changes

dotnet-maestro bot added 4 commits April 4, 2020 00:52

dougbu added 2 commits April 6, 2020 18:01

Do not take EFCore breaking change, 1 of 2

8dafb59

Do not take EFCore breaking change, 2 of 2

c3632d5

dotnet-maestro bot merged commit c0e6643 into master Apr 7, 2020

dotnet-maestro bot deleted the darc-master-217842ec-d103-4c2d-8832-d98a27c00c1d branch April 7, 2020 02:43

[master] Update dependencies from dotnet/efcore #20532

[master] Update dependencies from dotnet/efcore #20532

Uh oh!

Conversation

dotnet-maestro bot commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/efcore

Coherency Updates

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

dotnet-maestro bot commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

davidfowl commented Apr 5, 2020

Uh oh!

ajcvickers commented Apr 5, 2020

Uh oh!

dotnet-maestro bot commented Apr 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

davidfowl commented Apr 5, 2020

Uh oh!

dotnet-maestro bot commented Apr 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

AndriySvyryd commented Apr 6, 2020

Uh oh!

dotnet-maestro bot commented Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

dougbu commented Apr 6, 2020

Uh oh!

dotnet-maestro bot commented Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

AndriySvyryd commented Apr 6, 2020

Uh oh!

dotnet-maestro bot commented Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

AndriySvyryd commented Apr 6, 2020

Uh oh!

dotnet-maestro bot commented Apr 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

AndriySvyryd commented Apr 7, 2020

Uh oh!

dotnet-maestro bot commented Apr 7, 2020

Auto-Merge Status

Uh oh!

davidfowl commented Apr 7, 2020

Uh oh!

dotnet-maestro bot commented Apr 7, 2020

Auto-Merge Status

Uh oh!

dougbu commented Apr 7, 2020

Uh oh!

dotnet-maestro bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

AndriySvyryd commented Apr 7, 2020

Uh oh!

dotnet-maestro bot commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Auto-Merge Status

Uh oh!

dougbu commented Apr 7, 2020

Uh oh!

dougbu commented Apr 7, 2020

Uh oh!

dotnet-maestro bot commented Apr 3, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 3, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 5, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 5, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 6, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 6, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 6, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 6, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 7, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 7, 2020 •

edited

Loading

dotnet-maestro bot commented Apr 7, 2020 •

edited

Loading