Skip to content

[SignalR] Avoid deadlock with closing and user callbacks #19612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

BrennanConroy
Copy link
Member

Fixes #17584

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Mar 5, 2020
@BrennanConroy BrennanConroy added this to the 5.0.0-preview2 milestone Mar 5, 2020
@BrennanConroy BrennanConroy requested a review from davidfowl March 5, 2020 20:09
@davidfowl
Copy link
Member

Feels like we should back port this.

@BrennanConroy
Copy link
Member Author

cc @anurse

@analogrelay
Copy link
Contributor

@BrennanConroy BrennanConroy merged commit f053620 into master Mar 6, 2020
@BrennanConroy BrennanConroy deleted the brecon/ondeadlock branch March 6, 2020 23:25
wtgodbe pushed a commit that referenced this pull request Mar 25, 2020
…9664)

* [SignalR] Avoid deadlock with closing and user callbacks (#19612)

* fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignalR deadlocks client on internal server-side exceptions during nested InvokeAsync call
3 participants