[SignalR] Avoid deadlock with closing and user callbacks (#19612) #19664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
BrennanConroy
removed
the
Servicing-consider
halter73
reviewed
Mar 10, 2020
src/SignalR/clients/csharp/Client/test/UnitTests/HubConnectionTests.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Mar 10, 2020
src/SignalR/clients/csharp/Client/test/UnitTests/HubConnectionTests.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Mar 10, 2020
BrennanConroy
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
davidfowl
approved these changes
Mar 11, 2020
leecow
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19612
Description
If the server closed the client's connection while they were waiting on
InvokeAsyncin theirOn(...)handler, the client would deadlock.Customer Impact
Bug was reported by a customer at #17584
Can cause deadlocks in seemingly innocent code.
As a workaround, customers can refactor their code a bit to trigger
InvokeAsyncfrom theOn(...)method, but not wait for it inside theOn(...)method.Regression?
No
Risk
Very low, moved a wait during close to fix a deadlock scenario.