Skip to content

[master] Update hosted (AzDO) and BYOC (dnceng) agents used in our builds #19673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2020
Merged

[master] Update hosted (AzDO) and BYOC (dnceng) agents used in our builds #19673

merged 2 commits into from
Mar 9, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Mar 7, 2020

  • dotnet/aspnetcore-internal#3540
  • nit: Consistently use in / notin with Build.Reason
    • YAML was inconsistent and this aligns w/ the Arcade code

dougbu added 2 commits March 6, 2020 17:21
@dougbu
Update hosted (AzDO) and BYOC (dnceng) agents used in our builds
e984a7e 
- dotnet/aspnetcore-internal#3540
@dougbu
Merge remote-tracking branch 'origin/master' into dougbu/master/newer…
0bb20cc 
….agents.3540

- fixup one more agent request
- nit: Consistently use `in` / `notin` with `Build.Reason`
  - YAML was inconsistent and this aligns w/ the Arcade code
@dougbu dougbu requested review from HaoK and a team March 7, 2020 03:05
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 7, 2020
@dougbu dougbu mentioned this pull request Mar 7, 2020
Merged
HaoK
HaoK reviewed Mar 7, 2020
View reviewed changes
Copy link
Member

@HaoK HaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just for my information sake, what's the functional difference here? Build Reason can sometimes contain more than one reason which would fail our checks?

@dougbu
Copy link
Contributor Author

dougbu commented Mar 7, 2020

@HaoK as I said, changing this addressed a nit. There should be no functional difference but we were inconsistent in our YAML and when compared with the Arcade YAML files.

Of course, the Arcade YAML may be using in and notin for reasons 😈

@BrennanConroy
Copy link
Member

Can we merge this please? I think this is now causing failures on builds because mac10.13 is being blocked on AzDo for some reason.

@dougbu dougbu merged commit 0c3c6d8 into master Mar 9, 2020
@dougbu dougbu deleted the dougbu/master/newer.agents.3540 branch March 9, 2020 18:57
@analogrelay
Copy link
Contributor

Are we getting this in to preview 2? We're getting hit by the macOS 10.13 brownout there as well.

@dougbu
Copy link
Contributor Author

dougbu commented Mar 9, 2020

I have #19674 open already but wasn't clear on whether it was approved for merging 'til this morning. I'll go through the PRs for preview2 in a sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilchie Pilchie Pilchie approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@HaoK HaoK HaoK approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dougbu @BrennanConroy @analogrelay @Pilchie @JunTaoLuo @HaoK