Skip to content

[release/3.1] Update hosted (AzDO) and BYOC (dnceng) agents used in our builds #19675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

[release/3.1] Update hosted (AzDO) and BYOC (dnceng) agents used in our builds #19675

merged 1 commit into from
Mar 25, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Mar 7, 2020

  • dotnet/aspnetcore-internal#3540
  • nit: Consistently use in / notin with Build.Reason
    • YAML was inconsistent and this aligns w/ the Arcade code

@dougbu dougbu requested review from HaoK and a team March 7, 2020 03:14
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 7, 2020
@dougbu dougbu added * NO MERGE * Do not merge this PR as long as this label is present. tell-mode Indicates a PR which is being merged during tell-mode labels Mar 7, 2020
@dougbu
Copy link
Contributor Author

dougbu commented Mar 7, 2020

@Pilchie the most important part of this (given the March 23 deadline) is the macOS switch. Any objection to the rest (nits and using faster Windows Server agents) in a tell-mode fix?

@dougbu
Copy link
Contributor Author

dougbu commented Mar 7, 2020

NO-MERGE because the branches aren't open

@dougbu dougbu mentioned this pull request Mar 7, 2020
Merged
Pilchie
Pilchie approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@dougbu
Update hosted (AzDO) and BYOC (dnceng) agents used in our builds
5ed5c1c 
- dotnet/aspnetcore-internal#3540
- nit: Consistently use `in` / `notin` with `Build.Reason`
  - YAML was inconsistent and this aligns w/ the Arcade code
@dougbu dougbu force-pushed the dougbu/3.1/newer.agents.3540 branch from 9b450a8 to 5ed5c1c Compare March 25, 2020 18:18
@dougbu dougbu mentioned this pull request Mar 25, 2020
Merged
@dougbu
Copy link
Contributor Author

dougbu commented Mar 25, 2020

Redid the work to avoid later conflicts; actual changes are the same as before but based on a later git merge-base commit because 'release/2.1' is no longer relevant here.

@dougbu dougbu removed the * NO MERGE * Do not merge this PR as long as this label is present. label Mar 25, 2020
@dougbu dougbu merged commit 7582cfc into release/3.1 Mar 25, 2020
@dougbu dougbu deleted the dougbu/3.1/newer.agents.3540 branch March 25, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pilchie Pilchie Pilchie approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

@HaoK HaoK Awaiting requested review from HaoK

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @Pilchie @JunTaoLuo