[release/3.1] Move SDL validation to ringed release #21153
Conversation
ghost
added
the
area-infrastructure
eng/sdl-tsa-vars.config
Outdated
| -TsaProjectName DEVDIV | ||
| -TsaNotificationEmail [email protected] | ||
| -TsaCodebaseAdmin REDMOND\kevinpi | ||
| -TsaBugAreaPath DevDiv\ASP.NET Core |
There was a problem hiding this comment.
@jcagme does this need to be quoted, since it has a space?
There was a problem hiding this comment.
Both cases work, but in summary, no quotes needed
eng/sdl-tsa-vars.config
Outdated
| -TsaCodebaseAdmin REDMOND\kevinpi | ||
| -TsaBugAreaPath DevDiv\ASP.NET Core | ||
| -TsaIterationPath DevDiv | ||
| -TsaRepositoryName aspnetcore |
There was a problem hiding this comment.
@jcagme this & TsaCodebaseName weren't in our variable group, do we need them here?
There was a problem hiding this comment.
No, just add the things you know. If these are required for your repo in particular we'll know when this runs but, if things ran fine and you didn't have these removing them shouldn't hurt
There was a problem hiding this comment.
Actually my bad, answered before looking at your code. Since you are defining them in ci.yaml then yes, add them to this file as well
wtgodbe
added
* NO MERGE *
|
I didn't realize that doing in the 3.1 branch was also part of the plan, but might have missed something. |
@jcagme sent an email on Tuesday asking for this to be done in all shipping branches |
| -TsaRepositoryName "AspNetCore" | ||
| -TsaCodebaseName "AspNetCore" | ||
| -TsaPublish $True | ||
| -PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")' |
There was a problem hiding this comment.
Isn't this needed in eng/sdl-tsa-vars.config❔
| -TsaCodebaseName AspNetCore | ||
| -TsaOnboard $True | ||
| -TsaPublish $True | ||
| -PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml") |
There was a problem hiding this comment.
@jcagme is this the right syntax?
There was a problem hiding this comment.
If it worked before it should work since I'm passing the contents of the file wholesale as in https://github.com/dotnet/aspnetcore/pull/21153/files/60482346e29075a668155f0afaf6fe1ad6c4d1ca#diff-097cdf55e1a931b74fbfe48d7e41c8beL721
Moves SDL out of the repo build and into the ringed release pipeline, as per the goal of reducing build time. CC @Pilchie