Skip to content

[release/3.1] Move SDL validation to ringed release #21153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2020
Merged

[release/3.1] Move SDL validation to ringed release #21153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5d6126
Move SDL validation to ringed release
wtgodbe Apr 23, 2020
db41a03
Remove unneeded stuff
wtgodbe Apr 23, 2020
c3a804f
Add back variables
wtgodbe Apr 23, 2020
b866acd
fixup
wtgodbe Apr 23, 2020
6048234
Add missing param
wtgodbe May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .azure/pipelines/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ variables:
/p:DotNetPublishUsingPipelines=$(_PublishUsingPipelines)
/p:DotNetArtifactsCategory=$(_DotNetArtifactsCategory)

# used for post-build phases, internal builds only
- group: DotNet-AspNet-SDLValidation-Params
- ${{ if in(variables['Build.Reason'], 'PullRequest') }}:
- name: _BuildArgs
value: ''
Expand Down Expand Up @@ -714,18 +712,3 @@ stages:
# See https://github.com/dotnet/arcade/issues/2871
enableSymbolValidation: false
publishInstallersAndChecksums: true
# This is to enable SDL runs part of Post-Build Validation Stage
SDLValidationParameters:
enable: false
continueOnError: false
params: ' -SourceToolsList @("policheck","credscan")
-TsaInstanceURL $(_TsaInstanceURL)
-TsaProjectName $(_TsaProjectName)
-TsaNotificationEmail $(_TsaNotificationEmail)
-TsaCodebaseAdmin $(_TsaCodebaseAdmin)
-TsaBugAreaPath $(_TsaBugAreaPath)
-TsaIterationPath $(_TsaIterationPath)
-TsaRepositoryName "AspNetCore"
-TsaCodebaseName "AspNetCore"
-TsaPublish $True
-PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this needed in eng/sdl-tsa-vars.config❔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

12 changes: 12 additions & 0 deletions eng/sdl-tsa-vars.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
-SourceToolsList @("policheck","credscan")
-TsaInstanceURL https://devdiv.visualstudio.com/
-TsaProjectName DEVDIV
-TsaNotificationEmail [email protected]
-TsaCodebaseAdmin REDMOND\kevinpi
-TsaBugAreaPath "DevDiv\ASP.NET Core"
-TsaIterationPath DevDiv
-TsaRepositoryName AspNetCore
-TsaCodebaseName AspNetCore
-TsaOnboard $True
-TsaPublish $True
-PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)/eng/PoliCheckExclusions.xml")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcagme is this the right syntax?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it worked before it should work since I'm passing the contents of the file wholesale as in https://github.com/dotnet/aspnetcore/pull/21153/files/60482346e29075a668155f0afaf6fe1ad6c4d1ca#diff-097cdf55e1a931b74fbfe48d7e41c8beL721