Undo use of pipewriter in FileBufferingWriteStream #21833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavkm
commented
May 14, 2020
pranavkm
commented
- Removed DrainBufferAsync overload that accepts PipeWriter
- Added some tests
Tratcher
approved these changes
May 14, 2020
Pilchie
added
the
area-mvc
|
Reopen the original issue? |
|
The original issue should still be addressed because this retains separate streams for reads and writes. #21834 is the follow-up to figure out why PipeWriter fails. |
davidfowl
approved these changes
May 14, 2020
pranavkm
added a commit
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.