Skip to content

Revert "Undo use of pipewriter in FileBufferingWriteStream (#21833)" #23391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

Revert "Undo use of pipewriter in FileBufferingWriteStream (#21833)" #23391

merged 1 commit into from
Jun 30, 2020

Conversation

pranavkm
Copy link
Contributor

This reverts commit 48261fd.

@pranavkm pranavkm requested a review from davidfowl June 26, 2020 15:58
@pranavkm pranavkm added area-hosting area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jun 26, 2020
@pranavkm pranavkm added this to the 5.0.0-preview8 milestone Jun 26, 2020
@Tratcher
Copy link
Member

And we think it's better this time?

@pranavkm
Copy link
Contributor Author

We figured out why the benchmarks were producing warnings and addressed it: #21834 (comment). I haven't run the benchmarks since though.

@pranavkm
Copy link
Contributor Author

@davidfowl do we need to profile this before it goes in? I assume you tried this out at some point.

@pranavkm pranavkm merged commit 7da6931 into master Jun 30, 2020
@pranavkm pranavkm deleted the prkrishn/undo branch June 30, 2020 13:22
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-hosting Includes Hosting area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview8
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavkm @Tratcher @davidfowl @amcasey