Skip to content

Quarantine cert test #22320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2020
Merged

Quarantine cert test #22320

merged 2 commits into from
May 28, 2020

Conversation

ryanbrandenburg
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg requested a review from a team May 28, 2020 17:37
@ghost ghost added the area-servers label May 28, 2020
@BrennanConroy
Copy link
Member

Why aren't you also quarantining HttpsTests.HttpsHelloWorld which failed in the same test run?

dougbu
dougbu approved these changes May 28, 2020
View reviewed changes
src/Servers/IIS/IIS/test/Common.FunctionalTests/ClientCertificateTests.cs
@@ -43,6 +43,7 @@ public Task HttpsNoClientCert_NoClientCert(TestVariant variant)
}

[ConditionalTheory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/22319")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question: Does WhatsBroken also no longer show quarantined tests? @BrennanConroy I thought the main issue was around finding new failures, not tracking the quarantined tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WhatsBroken doesn't show anything anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worse than I thought ☹️

Guess issues will have to fill the gap for now. @ryanbrandenburg please do something distinctive w/ the issues you file so the leads can find them easily. A new label plus linking to them in your ops issue should be more than enough. Or, just assign them all to @Pilchie 😃

@dougbu
Copy link
Contributor

dougbu commented May 28, 2020

Why aren't you also quarantining HttpsTests.HttpsHelloWorld which failed in the same test run?

For details on that failure see dotnet/aspnetcore-internal#3604 (my ops rotation issue). That includes a link to the Helix log.

@Pilchie
Copy link
Member

Pilchie commented May 28, 2020

I think you meant to assign the issue, so I went ahead and did that.

@ryanbrandenburg
Copy link
Contributor Author

#22329

@ryanbrandenburg ryanbrandenburg merged commit 26ddefc into master May 28, 2020
@ryanbrandenburg ryanbrandenburg deleted the rybrande/QuarantineCertTests branch May 28, 2020 21:56
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy left review comments

@Tratcher Tratcher Tratcher approved these changes

@dougbu dougbu dougbu approved these changes

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ryanbrandenburg @BrennanConroy @dougbu @Pilchie @Tratcher @amcasey