Skip to content

Quarantine cert test #22320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020
Merged

Quarantine cert test #22320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab52593
Quarantine cert test
ryanbrandenburg May 28, 2020
e29da49
Quarantine HttpsHelloWorld test
ryanbrandenburg May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/ClientCertificateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public Task HttpsNoClientCert_NoClientCert(TestVariant variant)
}

[ConditionalTheory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/22319")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question: Does WhatsBroken also no longer show quarantined tests? @BrennanConroy I thought the main issue was around finding new failures, not tracking the quarantined tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WhatsBroken doesn't show anything anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worse than I thought ☹️

Guess issues will have to fill the gap for now. @ryanbrandenburg please do something distinctive w/ the issues you file so the leads can find them easily. A new label plus linking to them in your ops issue should be more than enough. Or, just assign them all to @Pilchie 😃

[MemberData(nameof(TestVariants))]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8)]
public Task HttpsClientCert_GetCertInformation(TestVariant variant)
Expand Down
1 change: 1 addition & 0 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/HttpsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public static TestMatrix TestVariants
.WithAllHostingModels();

[ConditionalTheory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/22329")]
[MemberData(nameof(TestVariants))]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8)]
public async Task HttpsHelloWorld(TestVariant variant)
Expand Down