Skip to content

Update async Dispose and methods references #22407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Jun 3, 2020
Merged

Update async Dispose and methods references #22407

2 commits merged into from
Jun 3, 2020

Conversation

hueifeng
Copy link
Contributor

@hueifeng hueifeng commented Jun 1, 2020

  • Dispose can be changed to DisposeAsync
  • The methods in the following code snippet are not available, it causes duplicate references
/// <summary>
/// <see cref="HelperResult.WriteTo(TextWriter)"/> is invoked
/// </summary>
/// <param name="result">The <see cref="HelperResult"/> to invoke</param>
protected void Write(HelperResult result)
{
     Write(result);
}

@hueifeng
Update async Dispose and methods references
480cef6 
- `Dispose` can be changed to  `DisposeAsync`
- The methods in the following code snippet are not available, it causes duplicate references

```
        /// <summary>
        /// <see cref="HelperResult.WriteTo(TextWriter)"/> is invoked
        /// </summary>
        /// <param name="result">The <see cref="HelperResult"/> to invoke</param>
        protected void Write(HelperResult result)
        {
            Write(result);
        }

```
@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 1, 2020
@pranavkm
Copy link
Contributor

pranavkm commented Jun 3, 2020

Thanks for the PR @hueifeng. There are compiler errors with the PR you sent. Can you fix these?

@hueifeng
Copy link
Contributor Author

hueifeng commented Jun 3, 2020

@pranavkm I submitted the changes.

pranavkm
pranavkm approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pranavkm pranavkm added this to the 5.0.0-preview7 milestone Jun 3, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

Hello @pranavkm!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 77ef004 into dotnet:master Jun 3, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
5.0.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@hueifeng @pranavkm @Pilchie