Skip to content

Update async Dispose and methods references #22407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Jun 3, 2020
Merged

Update async Dispose and methods references #22407

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
480cef6
Update async Dispose and methods references
hueifeng Jun 1, 2020
da6b6b9
Update BaseView.cs
hueifeng Jun 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Shared/RazorViews/BaseView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public async Task ExecuteAsync(Stream stream)
Output = new StreamWriter(buffer, UTF8NoBOM, 4096, leaveOpen: true);
await ExecuteAsync();
await Output.FlushAsync();
Output.Dispose();
await Output.DisposeAsync();
buffer.Seek(0, SeekOrigin.Begin);
await buffer.CopyToAsync(stream);
}
Expand All @@ -87,7 +87,7 @@ public async Task ExecuteAsync(HttpContext context)
Output = new StreamWriter(buffer, UTF8NoBOM, 4096, leaveOpen: true);
await ExecuteAsync();
await Output.FlushAsync();
Output.Dispose();
await Output.DisposeAsync();
buffer.Seek(0, SeekOrigin.Begin);
await buffer.CopyToAsync(Response.Body);
}
Expand Down Expand Up @@ -244,13 +244,13 @@ protected void WriteAttribute(
WriteLiteral(trailer);
}

/// <summary>
/// <summary>
/// <see cref="HelperResult.WriteTo(TextWriter)"/> is invoked
/// </summary>
/// <param name="result">The <see cref="HelperResult"/> to invoke</param>
protected void Write(HelperResult result)
{
Write(result);
result.WriteTo(Output);
}

/// <summary>
Expand Down