Enable control flow guard for IIS dlls

[jkotalik]

Enables control flow guards for IIS native dlls.

Will backport to 2.1 and 3.1 if this succeeds in master.

[blowdart]

LGTM

[BrennanConroy]

Ugly but 👍

[jkotalik]

I did the changes through the VS properties pages, so blame it for not simplifying these settings XD

[jkotalik]

@wtgodbe I think https://github.com/dotnet/aspnetcore/pull/22480/checks?check_run_id=732123555,

##[error]src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj(316,5): error MSB3491: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not write lines to file "F:\workspace\_work\1\s\artifacts\installers\Release\aspnetcoremodule.version". The process cannot access the file 'F:\workspace\_work\1\s\artifacts\installers\Release\aspnetcoremodule.version' because it is being used by another process.

may be failing due to bcd4fc0. I don't think PR should affect that file.

[wtgodbe]

@jkotalik where are you seeing that failure? I couldn't find it in the linked build. I'm not sure how bcd4fc0 could've caused that failure - it just changed the SiteExtension package to not copy files that start with a . character - it shouldn't affect the installer/IIS build, and it doesn't specifically target files with version in the name

[jkotalik]

First attempt here: https://dev.azure.com/dnceng/public/_build/results?buildId=668624&view=logs&j=5bc15395-7127-5cfd-df04-3bb55bc6c62d. I'm just as confused as you, it just seems potentially related.

[wtgodbe]

Appears that the failure was transient. Are there multiple version of the module that could be trying to write that file at the same time? We could file a follow-up issue to investigate

[Pilchie]

I'm guessing we should probably take this for July servicing of 3.1, right @blowdart?

[blowdart]

That would be appreciated

[dougbu]

Ugly but 👍

My comment would make this much prettier 😺

[dougbu]

Thanks @jkotalik❕

[davidni]

@Pilchie @blowdart can you confirm this will be included in the July servicing of 3.1?

[blowdart]

The hosting package isn't part of servicing per se, it's a separate install, so the VS auto upgrader wouldn't get it.

@dougbu When would this take effect? Should we be upping the version number on the IIS plugins to make it clear?

[jkotalik]

The Windows Hosting Bundle is part of servicing. The next hosting bundle that is released will have this fix it in. However, we would also need to insert ANCM into VS s.t. the next version of VS has this change in it.

What do you mean by IIS plugins? ANCM doesn't have IIS plugins directly if I'm understanding you correctly.

[dougbu]

@jkotalik has #22608 open for 2.1 and #22609 for 3.1. Is this needed in preview 6 too❔

[jkotalik]

@blowdart to decide as I'm uncertain.

[blowdart]

I meant ANCM. I was without coffee :)

Will ANCM's version change? Because I believe it should.

And yea, I'd do it everywhere, including preview 6, so it doesn't get lost.

[jkotalik]

Yes, ANCM's version will change.

[jkotalik]

PR for 5.0-preview6 here: #22480

[blowdart]

Thank you

[dougbu]

@jkotalik you pointed back to this PR. Think you meant #22714

[Pilchie]

@davidni - yes, that's our plan unless something goes wrong somehow...