[3.1] Enable control flow guard for IIS dlls #22609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
👀 |
|
@Pilchie question from my other PR:
|
|
I think tell mode is fine once the branch opens again. |
jkotalik
added
the
tell-mode
dougbu
approved these changes
Jun 9, 2020
Pilchie
added
Servicing-approved
Pilchie
removed
the
* NO MERGE *
|
@jkotalik @BrennanConroy - any idea about the failure? Seems unlikely this would break a SignalR test... |
|
Flaky test that was fixed in 5.0. It would be a little awkward to backport to 3.1 since we added a new feature (internal only) to fix it. |
|
Okay - I'll force merge this one. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #22480 to 3.1.