Cache HtmlContentBuilder's Entries' count for loops #23707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache the value of Entries.Count into a local when enumerating loops, rather than re-evaluating on each pass.
mkArtakMSFT
added
the
area-mvc
mkArtakMSFT
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the value of
Entries.Countinto a local when enumerating loops, rather than re-evaluating on each iteration.I've seen this approach used elsewhere in the code base for performance, and as this type is used as part of MVC view rendering I figured it would be worth the tweak.
The type itself doesn't have any micro-benchmarks, so I wasn't sure what to use to get some concrete numbers on before/after.