Skip to content

Cache HtmlContentBuilder's Entries' count for loops #23707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Cache HtmlContentBuilder's Entries' count for loops #23707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Html/Abstractions/src/HtmlContentBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ public void CopyTo(IHtmlContentBuilder destination)
throw new ArgumentNullException(nameof(destination));
}

for (var i = 0; i < Entries.Count; i++)
var count = Entries.Count;
for (var i = 0; i < count; i++)
{
var entry = Entries[i];

Expand Down Expand Up @@ -140,7 +141,8 @@ public void MoveTo(IHtmlContentBuilder destination)
throw new ArgumentNullException(nameof(destination));
}

for (var i = 0; i < Entries.Count; i++)
var count = Entries.Count;
for (var i = 0; i < count; i++)
{
var entry = Entries[i];

Expand Down Expand Up @@ -176,7 +178,8 @@ public void WriteTo(TextWriter writer, HtmlEncoder encoder)
throw new ArgumentNullException(nameof(encoder));
}

for (var i = 0; i < Entries.Count; i++)
var count = Entries.Count;
for (var i = 0; i < count; i++)
{
var entry = Entries[i];

Expand Down