Skip to content

Fix blocking call in FindByEmailAsync #24116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix blocking call in FindByEmailAsync #24116

merged 1 commit into from
Jul 22, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jul 20, 2020

Fixes #24113

@ghost ghost added the area-identity Includes: Identity and providers label Jul 20, 2020
@HaoK HaoK requested review from ajcvickers and blowdart July 20, 2020 16:34
@HaoK HaoK added this to the 5.0.0-rc1 milestone Jul 20, 2020
blowdart
blowdart approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously we'd test it too against the customer repo :)

@HaoK
Copy link
Member Author

HaoK commented Jul 20, 2020

Well, this one is so flagrantly incorrect, I'm pretty sure visual inspection is enough sadly

@HaoK HaoK marked this pull request as ready for review July 20, 2020 21:13
@HaoK HaoK merged commit e7b55df into master Jul 22, 2020
@HaoK HaoK deleted the haok/async branch July 22, 2020 22:04
@sgabler-solytic
Copy link

I already posted this message in #24113, but after more research, the actual PR seems like the better place to raise this:

Will this bugfix be available in 3.1.7? I checked this milestone here and didn't find this PR included: dotnet/aspnetcore/milestone/112

Maybe that's not the right place to check the progress of upcoming releases, but I just wanted to emphasize that including it in the next release would be highly appreciated. Thank you

@ajcvickers
Copy link
Contributor

@sgabler-solytic We are not currently planning to port this fix to 3.1.

This was referenced Sep 5, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowdart blowdart blowdart approved these changes

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
5.0.0-rc1
Development

Successfully merging this pull request may close these issues.

SNAT Port Exhaustion, Microsoft.AspNetCore.Identity.UserManager Async Calls Are blocking
4 participants
@HaoK @sgabler-solytic @ajcvickers @blowdart