-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix blocking call in FindByEmailAsync #50603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your PR, @cremor. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
/azp run |
Commenter does not have sufficient privileges for PR 50603 in repo dotnet/aspnetcore |
Great. How do I keep my own PR open? @halter73 Could you please review? |
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi @cakescience. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Make
FindByEmailAsync
actually an async method.Description
Seems like it was initially changed to a sync call as a workaround in #10660 by @ajcvickers. A part of the workaround was later removed in #11336 (again by @ajcvickers), but it stayed a sync call. Even later
UserStore.FindByEmailAsync
was made async again in #24116 (for #24113) by @HaoK, but theUserOnlyStore
was not fixed.Fixes #43973