Skip to content

Fix blocking call in FindByEmailAsync #50603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

cremor
Copy link
Contributor

@cremor cremor commented Sep 9, 2023

Make FindByEmailAsync actually an async method.

Description

Seems like it was initially changed to a sync call as a workaround in #10660 by @ajcvickers. A part of the workaround was later removed in #11336 (again by @ajcvickers), but it stayed a sync call. Even later UserStore.FindByEmailAsync was made async again in #24116 (for #24113) by @HaoK, but the UserOnlyStore was not fixed.

Fixes #43973

@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Sep 9, 2023
@ghost
Copy link

ghost commented Sep 9, 2023

Thanks for your PR, @cremor. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Contributor

@WeihanLi WeihanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Sep 21, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 21, 2023
@cremor
Copy link
Contributor Author

cremor commented Sep 21, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 50603 in repo dotnet/aspnetcore

@cremor
Copy link
Contributor Author

cremor commented Sep 21, 2023

Commenter does not have sufficient privileges for PR 50603 in repo dotnet/aspnetcore

Great. How do I keep my own PR open?

@halter73 Could you please review?

@martincostello
Copy link
Member

or by simply closing and reopening.

@halter73 halter73 removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 27, 2023
@halter73
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@halter73 halter73 enabled auto-merge (squash) September 27, 2023 21:55
@halter73 halter73 merged commit a9ddf72 into dotnet:main Sep 27, 2023
@ghost ghost added this to the 9.0-preview1 milestone Sep 27, 2023
@ghost
Copy link

ghost commented Sep 28, 2023

Hi @cakescience. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindByEmailAsync in the UserOnlyStore is not actually an Async call
4 participants