Move reconnection delay mechanism into framework code #24566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
reviewed
Aug 4, 2020
Great point! Done. |
captainsafia
approved these changes
Aug 5, 2020
|
@SteveSandersonMS Heads up that I'll be cherry-picking this into our servicing PR for the disconnect bug fix. |
captainsafia
pushed a commit
that referenced
this pull request
Aug 5, 2020
captainsafia
pushed a commit
that referenced
this pull request
Aug 13, 2020
wtgodbe
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Disconnect circuit on `beforeunload` event (#23224) * Add delay before showing Reconnection UI (#24137) * Add CSS delay before showing Reconnection UI * rebuild yet again to try and get past the conflict * Move reconnection delay mechanism into framework code (#24566) Co-authored-by: SQL-MisterMagoo <[email protected]> Co-authored-by: Steve Sanderson <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #24137, a delay was added before showing the reconnection dialog. At first this was implemented in JS, but I suggested moving the implementation into CSS so that we didn't have to worry about cases like "reconnection occurred during delay". This is great but has the drawback of complicating the
site.cssfile in the project template.I've since realised that a third and better option exists, which is a hybrid: implementing the delay in CSS (via
transition), but triggering it from JS. This retains the benefit of not risking inconsistency depending on the timing of reconnection, plus the benefit that it removes the extra code from the app developer's own CSS file.This PR makes that tweak, leaving the default delay at 500ms. Developers who want to override the delay can still easily do so using CSS. For example, to change it to 2 seconds: