Disconnect circuit on beforeunload event and fix display
#24592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
captainsafia
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
captainsafia
removed
the
Servicing-consider
SteveSandersonMS
approved these changes
Aug 7, 2020
Yeah, I wanted to make sure that @SQL-MisterMagoo got credit for his work in the backport even though we ended up modifying it. |
captainsafia
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
mkArtakMSFT
added
the
ask-mode
leecow
added
Servicing-approved
|
This is approved. @dougbu is working on getting the branding changes done, and then this can be merged for 3.1.8. |
* Add CSS delay before showing Reconnection UI * rebuild yet again to try and get past the conflict
captainsafia
force-pushed
the
safia/blaserver-connection
branch
from
b294349 to
cac0a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blazor's front-end logic implements some code to disconnect a circuit when a user navigates away from a page. Previously, this code was triggered on the
unloadDOM event. However, not all browsers trigger this event at the right time. As a result, we changed the cleanup logic to trigger earlier to ensure that circuits are properly disposed.This also includes some UI fixes to account for the fact that the disconnect happens before the webpage is unloaded.
Customer Impact
This issue was reported by a customer in #19050. It affects the experience for users of Blazor apps and ensures that unneeded circuits are properly disposed.
Without this change, a Blazor circuit might remain open on the server long after a user has left the page and consume unnecessary resources.
Regression?
No.
Risk
Low risk because the change is backwards-compatible.
Note: The macOS build is failing for an unrelated issue that is currently affecting all PR builds targeting 3.1. This issue is tracked at #24667.