Skip to content

Use preview queues for internal build #24683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Aug 7, 2020

The preview queue has VS 16.7 p5 which allows builds in master to run successfully.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 7, 2020
@pranavkm pranavkm marked this pull request as ready for review August 7, 2020 19:54
@pranavkm pranavkm requested review from wtgodbe and MattGal August 7, 2020 19:54
@wtgodbe wtgodbe requested review from dougbu and Pilchie August 7, 2020 20:04
@Pilchie
Copy link
Member

Pilchie commented Aug 7, 2020

Can we kick off an internal build on this branch to ensure that it actually works?

@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 7, 2020

@@ -115,7 +115,7 @@ jobs:
${{ if eq(variables['System.TeamProject'], 'internal') }}:
name: NetCoreInternal-Pool
# Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing
queue: BuildPool.Server.Amd64.VS2019
queue: BuildPool.Windows.10.Amd64.VS2019.Pre
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, the Prerelease Server queues were removed to save capacity. We can \ should switch back to Server once 16.7 or newer is available in the non-PRE queues.

@dougbu
Copy link
Contributor

dougbu commented Aug 7, 2020 via email

@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 7, 2020

@dougbu is there a reason to not use this until such a queue becomes available? The build appears to pass.

@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 7, 2020

I spoke to @MattGal offline and he recommends using this as long as it works for us. We should of course work to switch to a more appropriate queue once available.

@pranavkm pranavkm merged commit 407b623 into master Aug 7, 2020
@pranavkm pranavkm deleted the prkrishn/use-preview-queue branch August 7, 2020 23:46
@pranavkm pranavkm added this to the 5.0.0-rc1 milestone Aug 7, 2020
dougbu added a commit that referenced this pull request Aug 9, 2020
- go back to main VS2019 queues

This reverts commit 407b623.
dougbu added a commit that referenced this pull request Aug 9, 2020
- go back to main VS2019 queues

This reverts commit 407b623.
dougbu added a commit that referenced this pull request Aug 10, 2020
- go back to main VS2019 queues

This reverts commit 407b623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants