-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Use preview queues for internal build #24683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we kick off an internal build on this branch to ensure that it actually works? |
Already done and verified that it works: https://dev.azure.com/dnceng/internal/_build/results?buildId=761862&view=logs&j=1b89928a-2219-5ef9-602f-f95beb3da4dc&t=b8e57a46-4a1c-5752-600e-7a395fe90fb9 |
@@ -115,7 +115,7 @@ jobs: | |||
${{ if eq(variables['System.TeamProject'], 'internal') }}: | |||
name: NetCoreInternal-Pool | |||
# Visual Studio Enterprise - contains some stuff, like SQL Server and IIS Express, that we use for testing | |||
queue: BuildPool.Server.Amd64.VS2019 | |||
queue: BuildPool.Windows.10.Amd64.VS2019.Pre |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future reference, the Prerelease Server queues were removed to save capacity. We can \ should switch back to Server once 16.7 or newer is available in the non-PRE queues.
@dougbu is there a reason to not use this until such a queue becomes available? The build appears to pass. |
I spoke to @MattGal offline and he recommends using this as long as it works for us. We should of course work to switch to a more appropriate queue once available. |
- go back to main VS2019 queues This reverts commit 407b623.
- go back to main VS2019 queues This reverts commit 407b623.
- go back to main VS2019 queues This reverts commit 407b623.
The preview queue has VS 16.7 p5 which allows builds in master to run successfully.