Skip to content

Remove requirements for VS 16.7 #24713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Remove requirements for VS 16.7 #24713

merged 2 commits into from
Aug 10, 2020

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Aug 9, 2020

  • use signalr.npmproj (not Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj) to get non-stable version
    • add _GetPackageVersionInfo target to all *.npmproj projects
    • make _GetPackageVersionInfo target work when yarn is not installed
  • switch codesign-xplat.yml to use dotnet msbuild
    • above change also fixes Code-sign jobs but they're slightly faster using dotnet msbuild
  • revert "Use preview queues (Use preview queues for internal build #24683)"
    • go back to main VS2019 queues
    • this reverts commit 407b623

Test internal builds were both successful:

@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 9, 2020
@dougbu dougbu requested a review from a team August 9, 2020 04:07
dougbu added 2 commits August 9, 2020 12:01
- use SignalR.Npm.FunctionalTests.npmproj to get non-stable version
  - not Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj (avoid C# and F# projects)
  - add `_GetPackageVersionInfo` target to all `*.npmproj` projects
    - make `_GetPackageVersionInfo` target work when `yarn` is not installed
- switch codesign-xplat.yml to use `dotnet msbuild`
  - above change also fixes Code-sign jobs but they're slightly faster using `dotnet msbuild`
- go back to main VS2019 queues

This reverts commit 407b623.
@dougbu dougbu force-pushed the dougbu/different.versions branch from ac37106 to 6766f1d Compare August 9, 2020 19:39
@dougbu dougbu merged commit 9b4dd66 into master Aug 10, 2020
@dougbu dougbu deleted the dougbu/different.versions branch August 10, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants