Skip to content

Blazor flaky test sanctuary #26286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 29, 2020
Merged

Blazor flaky test sanctuary #26286

merged 14 commits into from
Sep 29, 2020

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Sep 24, 2020

Reenable a bunch of tests that seem to be behaving well (all have passed 100% in last 30 days on aspnetcore-quarantined-pr https://dev.azure.com/dnceng/public/_test/analytics?definitionId=869&contextType=build 172/172

Also turn off implicit waiting and explicitly call quit for selenium cleanup, as per:

https://www.selenium.dev/documentation/en/webdriver/waits/#implicit-wait
https://www.selenium.dev/documentation/en/webdriver/browser_manipulation/#quitting-the-browser-at-the-end-of-a-session

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Sep 24, 2020
@HaoK
Copy link
Member Author

HaoK commented Sep 25, 2020

Note: there was a big spike of test failures on 8/27 which all of these tests failed, none of these tests have failed in the last 30 days in the quarantined-pr pipeline excluding that one build

@HaoK HaoK merged commit 9f4d474 into master Sep 29, 2020
@HaoK HaoK deleted the haok/freedom branch September 29, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
2 participants