Skip to content

Blazor flaky test sanctuary #26286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 29, 2020
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
Browser.Exists(By.Id("culture-selector"));
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24692")]
[Theory]
[InlineData("en-US")]
[InlineData("fr-FR")]
Expand Down
3 changes: 0 additions & 3 deletions src/Components/test/E2ETest/Tests/BindTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,6 @@ public void CanBindTextboxShort()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23826")]
public void CanBindTextboxNullableShort()
{
var target = Browser.FindElement(By.Id("textbox-nullable-short"));
Expand Down Expand Up @@ -512,7 +511,6 @@ public void CanBindTextboxDouble()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23596")]
public void CanBindTextboxNullableDouble()
{
var target = Browser.FindElement(By.Id("textbox-nullable-double"));
Expand Down Expand Up @@ -612,7 +610,6 @@ public void CanBindTextboxNullableDecimal()
// This tests what happens you put invalid (unconvertable) input in. This is separate from the
// other tests because it requires type="text" - the other tests use type="number"
[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24756")]
public void CanBindTextbox_Decimal_InvalidInput()
{
var target = Browser.FindElement(By.Id("textbox-decimal-invalid"));
Expand Down
2 changes: 0 additions & 2 deletions src/Components/test/E2ETest/Tests/ErrorNotificationTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23643")]
public void ShowsErrorNotification_OnError_Dismiss()
{
var errorUi = Browser.FindElement(By.Id("blazor-error-ui"));
Expand All @@ -52,7 +51,6 @@ public void ShowsErrorNotification_OnError_Dismiss()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23596")]
public void ShowsErrorNotification_OnError_Reload()
{
var causeErrorButton = Browser.Exists(By.Id("throw-simple-exception"));
Expand Down
1 change: 0 additions & 1 deletion src/Components/test/E2ETest/Tests/EventCallbackTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ protected override void InitializeAsyncCore()
}

[Theory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23643")]
[InlineData("capturing_lambda")]
[InlineData("unbound_lambda")]
[InlineData("unbound_lambda_nested")]
Expand Down
1 change: 0 additions & 1 deletion src/Components/test/E2ETest/Tests/GlobalizationTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ public virtual void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string
// We need to do step 4 to make sure that the value we're entering can "stick" in the form field.
// We can't use ".Text" because DOM reasons :(
[Theory]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23643")]
[InlineData("en-US")]
[InlineData("fr-FR")]
public void CanSetCultureAndParseCultureInvariantNumbersAndDatesWithInputFields(string culture)
Expand Down
2 changes: 0 additions & 2 deletions src/Components/test/E2ETest/Tests/KeyTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ public void CanInsertUnkeyed()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24190")]
public void CanDeleteUnkeyed()
{
PerformTest(
Expand All @@ -112,7 +111,6 @@ public void CanDeleteUnkeyed()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24190")]
public void CanReorder()
{
PerformTest(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ protected override void InitializeAsyncCore()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25929")]
public void WebAssemblyConfiguration_Works()
{
// Verify values from the default 'appsettings.json' are read.
Expand Down
5 changes: 4 additions & 1 deletion src/Shared/E2ETesting/BrowserFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public async Task DisposeAsync()
var browsers = await Task.WhenAll(_browsers.Values);
foreach (var (browser, log) in browsers)
{
browser?.Quit();
browser?.Dispose();
}

Expand Down Expand Up @@ -320,7 +321,9 @@ private string UserProfileDirectory(string context)
capabilities,
TimeSpan.FromSeconds(60).Add(TimeSpan.FromSeconds(attempt * 60)));

driver.Manage().Timeouts().ImplicitWait = TimeSpan.FromSeconds(1);
// Make sure implicit waits are disabled as they don't mix well with explicit waiting
// see https://www.selenium.dev/documentation/en/webdriver/waits/#implicit-wait
driver.Manage().Timeouts().ImplicitWait = TimeSpan.Zero;
var logs = new RemoteLogs(driver);

return (driver, logs);
Expand Down