Stop shipping Blazor WASM templates in 3.1 patches #28492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
SteveSandersonMS
changed the title
|
@dotnet/aspnet-build are there any known issues with the mac checks on release/3.1? Its failed for me since yesterday |
|
Yeah, that's https://github.com/dotnet/core-eng/issues/11636 |
|
@pranavkm should I just go ahead and delete the files now too? |
javiercn
approved these changes
Dec 10, 2020
ryanbrandenburg
approved these changes
Dec 10, 2020
|
Ok I will update the PR to remove all the content as well now |
|
Is anyone aware of any files/content that live outside of the project templates directory for these wasm templates? The build is green but...? |
|
@HaoK AFAIK, template files don't exist outside of the templates for Blazor. |
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
leecow
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #25923
Description
The Blazor WASM template package is a going to be out of servicing support as of March. This change removes the code so it no longer will be built / shipped. We also plan to deprecate the package on nuget with a custom error message pointing at the current version of the template.
Customer impact
This was the first version of the WASM templates, and there are many fixes and scenarios that are only in 5.0+, the expectation was that most customers will need to upgrade to 5.0 and not remain on 3.2 indefinitely, especially since once out of support, not even security fixes will be ported to 3.2
Regression
No
Risk
Low. We are just removing the entire source directory along with the tests.