[3.1] Mark components assemblies as non shipping #31758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
HaoK
commented
Apr 13, 2021
| @@ -6,7 +6,7 @@ | |||
| <PackageTags>wasm;javascript;interop</PackageTags> | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| <IsPackable>true</IsPackable> | |||
| <IsShipping>true</IsShipping> | |||
| <IsShipping>false</IsShipping> | |||
There was a problem hiding this comment.
@dougbu is this the same as IsShippingPackage ?
There was a problem hiding this comment.
Sort of. The Arcade turns one into the other at https://github.com/dotnet/arcade/blob/e7ede87875f41a9b3df898ae08da5ebc96e24f56/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L22
pranavkm
approved these changes
Apr 13, 2021
No, branches are closed down for May. We should hold this until next month's check-in window |
wtgodbe
added
tell-mode
|
nit: @HaoK could you please use the GitHub UI features to make a bunch of suggestions in a comment, then batch committing those suggestions together❔ That'll take us from 15 emails to 2 when we're on your PRs 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #28492
Also mark WebAssembly packages as non shipping