Skip to content

[3.1] Mark components assemblies as non shipping #31758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 4, 2021
Merged

[3.1] Mark components assemblies as non shipping #31758

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9a5bad7
Update Microsoft.AspNetCore.Components.WebAssembly.csproj
HaoK Apr 13, 2021
0a41560
Update Microsoft.AspNetCore.Components.WebAssembly.Build.csproj
HaoK Apr 13, 2021
db3b101
Update Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj
HaoK Apr 13, 2021
c37952f
Update Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
HaoK Apr 13, 2021
3a2784c
Update Microsoft.JSInterop.WebAssembly.csproj
HaoK Apr 13, 2021
6810b5a
Update Microsoft.AspNetCore.Components.WebAssembly.Server.csproj
HaoK Apr 13, 2021
19d0927
Update Microsoft.Authentication.WebAssembly.Msal.csproj
HaoK Apr 13, 2021
150f3a9
Update Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.csproj
HaoK Apr 13, 2021
04bf785
Update Directory.Build.props
HaoK Apr 13, 2021
2bfb9a7
Update Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj
HaoK Apr 13, 2021
a7cb8f8
Update Microsoft.JSInterop.WebAssembly.csproj
HaoK Apr 14, 2021
eb3f437
Update Microsoft.Authentication.WebAssembly.Msal.csproj
HaoK Apr 14, 2021
d46a18a
Update Microsoft.AspNetCore.Components.WebAssembly.Build.csproj
HaoK Apr 14, 2021
5c5f68f
Update Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj
HaoK Apr 14, 2021
c3a74c6
Update Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
HaoK Apr 14, 2021
f102cd3
Update Directory.Build.props
HaoK Apr 14, 2021
91eb582
Update Microsoft.AspNetCore.Components.WebAssembly.Server.csproj
HaoK Apr 14, 2021
1149183
Update Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj
HaoK Apr 14, 2021
f1594ef
Update Microsoft.AspNetCore.Components.WebAssembly.csproj
HaoK Apr 14, 2021
dc4d57a
Update Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.csproj
HaoK Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ents/WebAssembly/Authentication.Msal/src/Microsoft.Authentication.WebAssembly.Msal.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<TargetFramework>netstandard2.1</TargetFramework>
<Description>Authenticate your Blazor webassembly applications with Azure Active Directory and Azure Active Directory B2C</Description>
<RazorLangVersion>3.0</RazorLangVersion>
<IsShippingPackage>false</IsShippingPackage>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...Components/WebAssembly/Build/src/Microsoft.AspNetCore.Components.WebAssembly.Build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<TargetName>Microsoft.AspNetCore.Components.WebAssembly.Build.Tasks</TargetName>
<AssemblyName>Microsoft.AspNetCore.Components.WebAssembly.Build</AssemblyName>
<Description>Build mechanism for ASP.NET Core Blazor WebAssembly applications.</Description>
<IsShippingPackage>true</IsShippingPackage>
<IsShippingPackage>false</IsShippingPackage>
<HasReferenceAssembly>false</HasReferenceAssembly>
<GenerateDependencyFile>false</GenerateDependencyFile>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion .../WebAssembly/DebugProxy/src/Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
<OutputType>Exe</OutputType>
<PackageId>Microsoft.AspNetCore.Components.WebAssembly.DebugProxy</PackageId>
<IsShippingPackage>true</IsShippingPackage>
<IsShippingPackage>false</IsShippingPackage>
<HasReferenceAssembly>false</HasReferenceAssembly>
<Description>Debug proxy for use when building Blazor applications.</Description>
<!-- Set this to false because assemblies should not reference this assembly directly, (except for tests, of course). -->
Expand Down
2 changes: 1 addition & 1 deletion ...ts/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<OutputType>Exe</OutputType>
<AssemblyName>blazor-devserver</AssemblyName>
<PackageId>Microsoft.AspNetCore.Components.WebAssembly.DevServer</PackageId>
<IsShippingPackage>true</IsShippingPackage>
<IsShippingPackage>false</IsShippingPackage>
<HasReferenceAssembly>false</HasReferenceAssembly>
<StartupObject>Microsoft.AspNetCore.Components.WebAssembly.DevServer.Program</StartupObject>
<Description>Development server for use when building Blazor applications.</Description>
Expand Down
5 changes: 4 additions & 1 deletion src/Components/WebAssembly/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
<!-- Override version labels -->
<VersionPrefix>$(ComponentsWebAssemblyVersionPrefix)</VersionPrefix>

<!-- Override shipping to be extra safe -->
<IsShippingPackage>false</IsShippingPackage>

<!-- Avoid source build issues with WebAssembly -->
<ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
</PropertyGroup>
</Project>
</Project>
2 changes: 1 addition & 1 deletion src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageTags>wasm;javascript;interop</PackageTags>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<IsPackable>true</IsPackable>
<IsShipping>true</IsShipping>
<IsShipping>false</IsShipping>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbu is this the same as IsShippingPackage ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. The Arcade turns one into the other at https://github.com/dotnet/arcade/blob/e7ede87875f41a9b3df898ae08da5ebc96e24f56/src/Microsoft.DotNet.Arcade.Sdk/tools/Version.BeforeCommonTargets.targets#L22

<HasReferenceAssembly>false</HasReferenceAssembly>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ...mponents/WebAssembly/Server/src/Microsoft.AspNetCore.Components.WebAssembly.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
<Description>Runtime server features for ASP.NET Core Blazor applications.</Description>
<IsShippingPackage>true</IsShippingPackage>
<IsShippingPackage>false</IsShippingPackage>
<HasReferenceAssembly>false</HasReferenceAssembly>

<!-- We're deliberately bundling assemblies as content files. Suppress the warning. -->
Expand Down
2 changes: 1 addition & 1 deletion ...mbly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<Description>Build client-side authentication for single-page applications (SPAs).</Description>
<IsShippingPackage>true</IsShippingPackage>
<IsShippingPackage>false</IsShippingPackage>
<HasReferenceAssembly>false</HasReferenceAssembly>
<RazorLangVersion>3.0</RazorLangVersion>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down
2 changes: 1 addition & 1 deletion ...Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCore.Components.WebAssembly.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.1</TargetFramework>
<Description>Build client-side single-page applications (SPAs) with Blazor running under WebAssembly.</Description>
<IsShippingPackage>true</IsShippingPackage>
<IsShippingPackage>false</IsShippingPackage>
<NoWarn>$(NoWarn);BL0006</NoWarn>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions ...WebAssemblyHttpHandler/src/Microsoft.AspNetCore.Components.WebAssembly.HttpHandler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<ProduceOnlyReferenceAssembly>true</ProduceOnlyReferenceAssembly>
<StrongNameKeyId>Open</StrongNameKeyId>
<IsProjectReferenceProvider>false</IsProjectReferenceProvider>
<IsShippingPackage>false</IsShippingPackage>
</PropertyGroup>

<ItemGroup>
Expand Down