Skip to content

Enable SpaServices tests on helix #29247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
11 commits merged into from
Jan 21, 2021
Merged

Enable SpaServices tests on helix #29247

11 commits merged into from
Jan 21, 2021

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jan 12, 2021 •
edited
Loading

Fixes #18672

Clean up install node so spa services is able to find it on helix runs

@HaoK HaoK requested a review from a team January 13, 2021 03:04
@HaoK HaoK marked this pull request as ready for review January 13, 2021 03:04
@HaoK HaoK requested a review from Tratcher as a code owner January 13, 2021 03:04
HaoK
HaoK commented Jan 13, 2021
View reviewed changes
@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 13, 2021
captainsafia
captainsafia approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to the scripts makes sense to me.

Test failure seems unrelated to these changes.

@HaoK
Copy link
Member Author

HaoK commented Jan 20, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@ghost
Copy link

ghost commented Jan 21, 2021

Hello @HaoK!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 699b80f into master Jan 21, 2021
@ghost ghost deleted the haok/spa branch January 21, 2021 19:01
@halter73 halter73 mentioned this pull request Jan 22, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helix] enable Microsoft.AspNetCore.SpaServices.Extensions.Tests
3 participants
@HaoK @captainsafia @Pilchie