Alway skip failing UseSpa tests on Alpine #29552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-mvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like merely skipping the helix queue didn't prevent the test from running on Alpine as part of aspnetcore-helix-matrix. It started failing consistently after #29247 was merged yesterday.
https://dev.azure.com/dnceng/public/_build/results?buildId=961017&view=ms.vss-test-web.build-test-results-tab
I'm not sure why the previous SkipOnHelix attributes didn't prevent this since the name seems correct, but as with the GrpcTemplate test, it's better just to read
/etc/os-releaseto see if we're running on Alpine because this works outside of helix anyway. See #27262 for some previous discussion about this.