Skip to content

Fix MSB4062 when building Microsoft.Web.Xdt.Extensions #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2018
Merged

Fix MSB4062 when building Microsoft.Web.Xdt.Extensions #4083

merged 1 commit into from
Nov 19, 2018

Conversation

natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Nov 19, 2018 •
edited
Loading

Build fails with this error when build tools are updated automatically:

error MSB4062: The "Microsoft.AspNetCore.BuildTools.Sdk_GetAssemblyFileVersion" task could not be loaded from the assembly

This ensures Microsoft.Web.Xdt.Extensions.csproj uses the same version of build tools as the rest of the repo.

Other changes:

  • Resolve build warnings about source link and API check
  • Set IsPackable=false instead of using ExcludeFromPack

Resolves https://github.com/aspnet/AspNetCore-Internal/issues/1360

@natemcmaster natemcmaster requested a review from pakrym November 19, 2018 19:18
@natemcmaster natemcmaster merged commit 9954f5a into master Nov 19, 2018
@natemcmaster natemcmaster deleted the namc/xdt branch November 19, 2018 19:26
dougbu added a commit that referenced this pull request Oct 13, 2019
@dougbu
Use latest Arcade from '.NET 3 Tools'
1541cd4 
- pick up @joeloff's #4083 signing validation fixes
dougbu added a commit that referenced this pull request Nov 5, 2019
@dougbu
Use latest Arcade from '.NET 3 Tools'
0e31e6d 
- pick up @joeloff's #4083 signing validation fixes
dougbu added a commit that referenced this pull request Nov 6, 2019
@dougbu
Use latest Arcade from '.NET 3 Tools'
48e3c89 
- pick up @joeloff's #4083 signing validation fixes
dougbu added a commit that referenced this pull request Nov 19, 2019
@dougbu
Re-enable signing validation (#13899)
4ba64f5 
- #13864
- use latest Arcade from '.NET 3 Tools'
  - pick up @joeloff's #4083 signing validation fixes
- update signing validation exclusions to get them working
- remove custom embedded package icon bits and use Arcade approach
  - also switch VS.Redist.* packages to use license expressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym pakrym pakrym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natemcmaster @pakrym