Skip to content

Fix MSB4062 when building Microsoft.Web.Xdt.Extensions #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/repo.props
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</ItemGroup>

<ItemGroup>
<SamplesProject Include="$(RepositoryRoot)src\samples\**\*.csproj;"/>
<SamplesProject Include="$(RepositoryRoot)src\**\samples\**\*.csproj;"/>

<ProjectToExclude Include="@(SamplesProject)" Condition="'$(BuildSamples)' == 'false' "/>

Expand Down
5 changes: 5 additions & 0 deletions src/SiteExtensions/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,9 @@
<Import Project="build\dependencies.props" />
<Import Project="version.props" />

<PropertyGroup>
<EnableApiCheck>false</EnableApiCheck>
<GenerateSourceLinkFile>false</GenerateSourceLinkFile>
</PropertyGroup>

</Project>
7 changes: 2 additions & 5 deletions src/SiteExtensions/build/dependencies.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,11 @@
<MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
</PropertyGroup>

<Import Project="..\..\..\build\dependencies.props" />

<PropertyGroup Label="Package Versions">
<InternalAspNetCoreSdkPackageVersion>3.0.0-build-20181114.5</InternalAspNetCoreSdkPackageVersion>
<MicrosoftAspNetCoreAzureAppServicesSiteExtension21PackageVersion>2.1.1-rtm-31076</MicrosoftAspNetCoreAzureAppServicesSiteExtension21PackageVersion>
<MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion>2.2.0-rtm-35515</MicrosoftAspNetCoreAzureAppServicesSiteExtension22PackageVersion>
<MicrosoftNETTestSdkPackageVersion>15.6.1</MicrosoftNETTestSdkPackageVersion>
<MicrosoftWebXdtPackageVersion>1.4.0</MicrosoftWebXdtPackageVersion>
<XunitPackageVersion>2.4.0</XunitPackageVersion>
<XunitRunnerVisualStudioPackageVersion>2.4.0</XunitRunnerVisualStudioPackageVersion>
</PropertyGroup>

</Project>
9 changes: 4 additions & 5 deletions src/SiteExtensions/build/repo.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<Project>


<ItemGroup>
<ExcludeFromPack Include="$(RepositoryRoot)src\Microsoft.Web.Xdt.Extensions\*.csproj" />
</ItemGroup>

<PropertyGroup>
<!-- Disable KoreBuild restrictions while we re-work dependency management. -->
<DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions>
</PropertyGroup>
</Project>
4 changes: 2 additions & 2 deletions src/SiteExtensions/global.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"sdk": {
"version": "2.2.100-preview3-009430"
"version": "3.0.100-preview-009750"
},
"msbuild-sdks": {
"Internal.AspNetCore.Sdk": "3.0.0-alpha1-20181018.6"
"Internal.AspNetCore.Sdk": "3.0.0-build-20181114.5"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@
<PropertyGroup>
<Description>Additional functionality for Xdt transforms.</Description>
<TargetFramework>net461</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageTags>xdt</PackageTags>
<IsPackable>false</IsPackable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Web.Xdt" Version="$(MicrosoftWebXdtPackageVersion)" />
</ItemGroup>

</Project>
</Project>