-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/8.0] Update dependencies from dotnet/source-build-externals #50159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Update dependencies from dotnet/source-build-externals #50159
Conversation
…nals build 20230814.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23414.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving dependency update.
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
…nals build 20230817.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23417.1
Failure is:
|
@dotnet/source-build-internal Not sure what's going on here. Is this normal? I read the doc at https://github.com/dotnet/source-build/blob/main/Documentation/eliminating-pre-builts.md and it's all about how people shouldn't add new dependencies on prebuilts. That makes sense, but in this PR, the new prebuilt is coming from source-build-externals. So, should it be allowed? Should it be added to |
This is because we updated the version of Newtonsoft.Json that we source build: dotnet/source-build-externals#189. It's still ok to reference 13.0.1 but we need the changes from dotnet/source-build-reference-packages#768 to flow into aspnetcore first. |
…nals build 20230818.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23418.1
…nals build 20230821.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23421.1
This pull request updates the following dependencies
From https://github.com/dotnet/source-build-externals