Skip to content

[release/8.0] Update dependencies from dotnet/source-build-externals #50159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 17, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-externals

  • Subscription: 3dc3d394-290e-43ab-8e2f-08db9e435944
  • Build: 20230821.1
  • Date Produced: August 21, 2023 1:44:11 PM UTC
  • Commit: 1bc73adce07951fc0931ebd2b93492db78c538df
  • Branch: refs/heads/main

…nals build 20230814.2

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23414.2
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners August 17, 2023 19:50
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Aug 17, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost
Copy link

ghost commented Aug 17, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

…nals build 20230817.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23417.1
@SteveSandersonMS
Copy link
Member

Failure is:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23411.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 1 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Newtonsoft.Json.13.0.1

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Aug 18, 2023

@dotnet/source-build-internal Not sure what's going on here. Is this normal?

I read the doc at https://github.com/dotnet/source-build/blob/main/Documentation/eliminating-pre-builts.md and it's all about how people shouldn't add new dependencies on prebuilts. That makes sense, but in this PR, the new prebuilt is coming from source-build-externals. So, should it be allowed? Should it be added to eng\SourceBuildPrebuiltBaseline.xml?

@mthalman
Copy link
Member

This is because we updated the version of Newtonsoft.Json that we source build: dotnet/source-build-externals#189. It's still ok to reference 13.0.1 but we need the changes from dotnet/source-build-reference-packages#768 to flow into aspnetcore first.

…nals build 20230818.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23418.1
…nals build 20230821.1

Microsoft.SourceBuild.Intermediate.source-build-externals
 From Version 8.0.0-alpha.1.23410.1 -> To Version 8.0.0-alpha.1.23421.1
@dotnet-maestro dotnet-maestro bot merged commit 8cb6c4e into release/8.0 Aug 21, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-release/8.0-dacdfd7f-1fa7-4618-9c9b-3dc4fafb8dd8 branch August 21, 2023 15:39
@ghost ghost added this to the 8.0-rc2 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants