Add Newtonsoft.Json.13.0.1 #768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
requested review from
MichaelSimons and
oleksandr-didyk
as code owners
|
The build is failing because the project is not configured with the signing key: But there is no .snk file published for Newtonsoft.Json that we can include in this repo. So this is blocked at this point. I'm going to revert dotnet/source-build-externals#189 until this can be resolved. |
|
I think we want to get repo owners to upgrade so that everyone is on the same version - 13.0.3. We should avoid adding non-msft reference packages. |
|
Closing based on #768 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the upgrade of Newtonsoft.Json to 13.0.3 in source-build-externals, we need the previous version of 13.0.1 to be available in SBRP so that repos can still reference 13.0.1.