Skip to content

Add ForgotPasswordRequest to STJ source generation context #52714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add ForgotPasswordRequest to STJ source generation context #52714

merged 1 commit into from
Dec 13, 2023

Conversation

joegoldman2
Copy link
Contributor

Fixes #52646.

@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Dec 11, 2023
@ghost
Copy link

ghost commented Dec 11, 2023

Thanks for your PR, @joegoldman2. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Kahbazi Kahbazi requested a review from halter73 December 11, 2023 07:58
@amcasey
Copy link
Member

amcasey commented Dec 12, 2023

Build failure seems unrelated.

Agreed. Some sort of race.

@amcasey amcasey merged commit bf56300 into dotnet:main Dec 13, 2023
@ghost ghost added this to the 9.0-preview1 milestone Dec 13, 2023
@joegoldman2 joegoldman2 deleted the fix/52646 branch December 13, 2023 18:59
Kahbazi pushed a commit to Kahbazi/AspNetCore that referenced this pull request Dec 14, 2023
@Kahbazi
Copy link
Member

Kahbazi commented Dec 14, 2023

@halter73 @amcasey Is this PR should be also backported to release/8.0 branch?

@ghost
Copy link

ghost commented Dec 14, 2023

Hi @Kahbazi. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey
Copy link
Member

amcasey commented Dec 14, 2023

If the type existed in 8.0, then yes it should be backported.

@ghost
Copy link

ghost commented Dec 14, 2023

Hi @amcasey. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForgotPasswordRequest is not included in IdentityEndpointsJsonSerializerContext
4 participants