Skip to content

[release/8.0] Add ForgotPasswordRequest to STJ source generation context #52830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

Kahbazi
Copy link
Member

@Kahbazi Kahbazi commented Dec 14, 2023

Manual backport of #52714

Add ForgotPasswordRequest to STJ source generation context

Add ForgotPasswordRequest to IdentityEndpointsJsonSerializerContext for ApiEndpoints.

Description

Fixes #52646

Customer Impact

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

/cc @halter73 @amcasey

@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Dec 14, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

Thanks for your PR, @Kahbazi. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost ghost added this to the 8.0.x milestone Dec 14, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

Hi @Kahbazi. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@Kahbazi Kahbazi added the Servicing-consider Shiproom approval is required for the issue label Dec 14, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

Hi @Kahbazi. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT
Copy link
Contributor

Thanks for your PR, @Kahbazi.
@halter73 what do you think about considering this for servicing?

@mkArtakMSFT mkArtakMSFT removed the Servicing-consider Shiproom approval is required for the issue label Dec 18, 2023
@mkArtakMSFT
Copy link
Contributor

I've removed the Servicing-consider label for now, until I hear back from @halter73

@amcasey
Copy link
Member

amcasey commented Dec 18, 2023

Oops, evidently I jumped the gun. This has already been approved over email, but I'll certainly defer to @halter73's guidance.

@halter73
Copy link
Member

@mkArtakMSFT We should take it. It's a trivial bugfix which has already been approved by tactics. Thanks @amcasey

@ghost
Copy link

ghost commented Dec 27, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 27, 2023
@halter73
Copy link
Member

halter73 commented Jan 20, 2024

@dotnet/aspnet-build Can someone merge this? @amcasey should be able to confirm this was approved December 14th. The email subject was "[release/8.0] Fix aspnetcore AOT bug".

@dotnet dotnet deleted a comment from azure-pipelines bot Jan 20, 2024
@halter73
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amcasey
Copy link
Member

amcasey commented Jan 22, 2024

@dotnet/aspnet-build Can someone merge this? @amcasey should be able to confirm this was approved December 14th. The email subject was "[release/8.0] Fix aspnetcore AOT bug".

Confirmed - tactics approved over email 12/14.

@wtgodbe wtgodbe added the Servicing-approved Shiproom has approved the issue label Jan 22, 2024
@halter73 halter73 removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 2, 2024
@wtgodbe wtgodbe merged commit a7ed28a into dotnet:release/8.0 Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.3 Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member Servicing-approved Shiproom has approved the issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants