[Blazor] Blazor InputRadio is broken by IHandleEvent #53245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Looks good! |
javiercn
force-pushed
the
javiercn/issue-52069
branch
from
219459d to
80e6046
Compare
SteveSandersonMS
approved these changes
Jan 10, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7477275680 |
11 tasks
1 task
mkArtakMSFT
pushed a commit
that referenced
this pull request
Jan 16, 2024
…53270) Backport of #53245 to release/8.0 /cc @javiercn # [Blazor] Blazor InputRadio is broken by IHandleEvent Update `InputRadioContext` to get the `CurrentValue` directly from the `InputRadioGroup` rather than using a copy that needs to be updated. ## Description Input radio groups did not update their values correctly when the component that used them implemented IHandleEvent. When the user clicked on the input radio, the value would not be updated in the UI. Fixes #52069 ## Customer Impact Input radio elements are not correctly updated when the component that uses them implements IHandleEvent. ## Regression? - [X] Yes - [ ] No 7.0 ## Risk - [ ] High - [ ] Medium - [X] Low [Justify the selection above] ## Verification - [ ] Manual (required) - [X] Automated ## Packaging changes reviewed? - [ ] Yes - [ ] No - [x] N/A ---- ## When servicing release/2.1 - [ ] Make necessary changes in eng/PatchConfig.props --------- Co-authored-by: jacalvar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add an E2E test for this. But the TL;DR is as follows:
The
CurrentValueproperty in the context was being initialized the first time, but was not being updated afterwards even though it changed on the InputRadioGroup. That meant that InputRadio components would not see the value immediately as part of the first render.This was working on other scenarios because the default implementation in ComponentBase will trigger a re-render of the parent component, which in turn will trigger a re-render of the InputGroup component (since it receives a render fragment) and at that point, the component would update the parameter and the re-render of the individual InputRadio elements would work.
When someone implements IHandleEvent, that doesn't necessarily happen, hence the reason for the bug. The fix is to avoid updating the value in the context as a separate step and instead making the context reflect the value from the input.