Skip to content

[release/8.0] [Blazor] Blazor InputRadio is broken by IHandleEvent #53270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 10, 2024

Backport of #53245 to release/8.0

/cc @javiercn

[Blazor] Blazor InputRadio is broken by IHandleEvent

Update InputRadioContext to get the CurrentValue directly from the InputRadioGroup rather than using a copy that needs to be updated.

Description

Input radio groups did not update their values correctly when the component that used them implemented IHandleEvent. When the user clicked on the input radio, the value would not be updated in the UI.

Fixes #52069

Customer Impact

Input radio elements are not correctly updated when the component that uses them implements IHandleEvent.

Regression?

  • Yes
  • No

7.0

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@github-actions github-actions bot requested a review from a team as a code owner January 10, 2024 15:39
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 10, 2024
@ghost ghost added this to the 8.0.x milestone Jan 10, 2024
@ghost
Copy link

ghost commented Jan 10, 2024

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@mkArtakMSFT mkArtakMSFT added the Servicing-consider Shiproom approval is required for the issue label Jan 11, 2024
@ghost
Copy link

ghost commented Jan 11, 2024

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 12, 2024
@ghost
Copy link

ghost commented Jan 12, 2024

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@mkArtakMSFT mkArtakMSFT merged commit e74a5cf into release/8.0 Jan 16, 2024
@mkArtakMSFT mkArtakMSFT deleted the backport/pr-53245-to-release/8.0 branch January 16, 2024 16:45
@ghost ghost modified the milestones: 8.0.x, 8.0.2 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants