Skip to content

Update .NET SDK to 9.0.100-preview.3.24153.2 #54345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 4, 2024

Updates the .NET SDK to version 9.0.100-preview.3.24153.2, which also updates the .NET runtime from version 9.0.0-preview.2.24109.4 to version 9.0.0-preview.3.24129.2.

This pull request was auto-generated by GitHub Actions.

Update .NET SDK to version 9.0.100-preview.3.24153.2.

---
updated-dependencies:
- dependency-name: Microsoft.NET.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot requested review from wtgodbe and a team as code owners March 4, 2024 12:11
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 4, 2024
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving SDK update.

@eerhardt
Copy link
Member

eerhardt commented Mar 4, 2024

@lewing @javiercn @dsplaisted @marcpopMSFT - The components e2e tests are failing with:

  Restore was successful.
  All projects are up-to-date for restore.
  Determining projects to restore...
  All projects are up-to-date for restore.
  GenerateFiles -> /home/vsts/work/1/s/artifacts/bin/GenerateFiles/Directory.Build.props
  GenerateFiles -> /home/vsts/work/1/s/artifacts/bin/GenerateFiles/Directory.Build.targets
  GenerateFiles -> /home/vsts/work/1/s/.config/dotnet-tools.json
  Runtime toolset 'dotnet/x64 v9.0.0-preview.3.24154.1' already installed.
  Determining projects to restore...
/home/vsts/work/1/s/.dotnet/sdk/9.0.100-preview.3.24153.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/home/vsts/work/1/s/src/Components/WebAssembly/testassets/ThreadingApp/ThreadingApp.csproj]
/home/vsts/work/1/s/.dotnet/sdk/9.0.100-preview.3.24153.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/home/vsts/work/1/s/src/Components/WebAssembly/testassets/ThreadingApp/ThreadingApp.csproj]

Build FAILED.

/home/vsts/work/1/s/.dotnet/sdk/9.0.100-preview.3.24153.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: wasm-tools [/home/vsts/work/1/s/src/Components/WebAssembly/testassets/ThreadingApp/ThreadingApp.csproj]
/home/vsts/work/1/s/.dotnet/sdk/9.0.100-preview.3.24153.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/home/vsts/work/1/s/src/Components/WebAssembly/testassets/ThreadingApp/ThreadingApp.csproj]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:55.65
Build failed with exit code 1. Check errors above.

Looks like there is a problem with the latest .NET 9.0 SDK. Can someone take a look?

@javiercn
Copy link
Member

javiercn commented Mar 4, 2024

/cc @maraf thoughts?

@maraf
Copy link
Member

maraf commented Mar 4, 2024

Multi-theaded apps now require workload, based on dotnet/runtime#98496

@dsplaisted
Copy link
Member

Sounds like either the tests need to be updated to not use WasmEnableThreads, or the wasm-tools workload needs to be installed before the tests are run.

@eerhardt
Copy link
Member

eerhardt commented Mar 4, 2024

Multi-theaded apps now require workload, based on dotnet/runtime#98496

Is a breaking change doc needed for this change?

@maraf
Copy link
Member

maraf commented Mar 4, 2024

Is a breaking change doc needed for this change?

Threads are still experimental

@eerhardt
Copy link
Member

eerhardt commented Mar 4, 2024

@MackinnonBuck @javiercn @mkArtakMSFT - Can someone on the Blazor team fix the tests to unblock moving to the latest 9.0 SDK?

@maraf
Copy link
Member

maraf commented Mar 5, 2024

Revert is the queue dotnet/runtime#99280

@dsplaisted
Copy link
Member

What's the longer term plan? It seems like the change being reverted was something we want to do (so that people will get a build time failure instead of a runtime failure).

@maraf
Copy link
Member

maraf commented Mar 5, 2024

What's the longer term plan? It seems like the change being reverted was something we want to do (so that people will get a build time failure instead of a runtime failure).

The workload is not needed per se for the multi-threaded wasm apps.
We have some issues with incremental build and switch between ST/MT which caused the originaly reported issue.

@sebastienros
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amcasey
Copy link
Member

amcasey commented Mar 7, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor Author

Superseded by #54483.

@github-actions github-actions bot closed this Mar 11, 2024
@github-actions github-actions bot deleted the update-dotnet-sdk-9.0.100-preview.3.24153.2 branch March 11, 2024 12:07
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview3 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants