-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Update .NET SDK to 9.0.100-preview.3.24161.2 #54483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update .NET SDK to version 9.0.100-preview.3.24161.2. --- updated-dependencies: - dependency-name: Microsoft.NET.Sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approving SDK update.
@wtgodbe - why does the bot close and open new PRs every week? It makes tracking the issues a lot harder. |
It's the default behaviour of my action to prevent unmerged PRs piling up. If that's not desired, it can be turned off by setting |
if (buffer == null) | ||
{ | ||
throw new ArgumentNullException(nameof(buffer)); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Span can't be null. I looked at other TextReader
implementations and they all no-op and return a read count of 0. Removed this check.
src/Mvc/Mvc.Core/src/Builder/ControllerActionEndpointConventionBuilder.cs
Show resolved
Hide resolved
Does that also stop a new PR from being opened? Why not just push to the existing PR? That's how maestro updates work. |
It won't stop a new PR if there's a newer SDK version available, but it doesn't currently support pushing over the top like with Maestro. I wouldn't be against pull requests to add that functionality though 😉 |
Updates the .NET SDK to version
9.0.100-preview.3.24161.2
, which also updates the .NET runtime from version9.0.0-preview.2.24109.4
to version9.0.0-preview.3.24160.3
.This pull request was auto-generated by GitHub Actions.