Update buildtools to 3.0.0-build-20190123.3 #6959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
approved these changes
Jan 23, 2019
| @@ -1,2 +1,2 @@ | |||
| version:3.0.0-build-20190122.3 | |||
| commithash:43e5fa8e3d8b192e573c3c14ae39b43e1d05cd5e | |||
| version:3.0.0-build-20190123.3 | |||
There was a problem hiding this comment.
Ick. Is there any way to propagate this version from a single source of truth (preferably this file)? Annoying to need to change multiple locations.
Or, please point me to the script which does the needful 😸
There was a problem hiding this comment.
I usually do this:
rm korebuild-lock.txt
build.cmd /t:Noop
That re-generates korebuild-lock.txt and global.json. Then, I manually update eng/Versions.props to match. The version in eng/Versions.props is only there to make Visual Studio happy. Command-line builds are always in-sync with the version in korebuild-lock.txt.
We could get rid of eng/Versions.props by replacing the PackageReference to Internal.AspNetCore.Sdk with a proper 'MSBuild Sdk', but that's not something I want to tackle just yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/aspnet/AspNetCore-Internal/issues/1707