Skip to content

Update buildtools to 3.0.0-build-20190123.3 #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Update buildtools to 3.0.0-build-20190123.3 #6959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d4b257
Update buildtools to 3.0.0-build-20190123.3
Jan 23, 2019
2d31871
Update signcheck.exclusions.txt
natemcmaster Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
</PropertyGroup>
<PropertyGroup Label="Build tool dependencies">
<InternalAspNetCoreSdkPackageVersion>$(KoreBuildVersion)</InternalAspNetCoreSdkPackageVersion>
<InternalAspNetCoreSdkPackageVersion Condition=" '$(KoreBuildVersion)' == '' ">3.0.0-build-20190122.3</InternalAspNetCoreSdkPackageVersion>
<InternalAspNetCoreSdkPackageVersion Condition=" '$(KoreBuildVersion)' == '' ">3.0.0-build-20190123.3</InternalAspNetCoreSdkPackageVersion>
<MicrosoftNETFrameworkReferenceAssembliesPackageVersion>1.0.0-alpha-004</MicrosoftNETFrameworkReferenceAssembliesPackageVersion>
<MicrosoftNETTestSdkPackageVersion>15.9.0</MicrosoftNETTestSdkPackageVersion>
</PropertyGroup>
Expand Down
4 changes: 2 additions & 2 deletions eng/signcheck.exclusions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ content/*.js;Microsoft.DotNet.Web.Spa.ProjectTemplates.*.nupkg; Exclude JavaScri
content/*.js;Microsoft.DotNet.Web.ProjectTemplates.*.nupkg; Exclude JavaScript files from codesigning in project templates
Templates/*.js;Microsoft.VisualStudio.Web.CodeGenerators.Mvc.*.nupkg; Exclude JavaScript files from codesigning in code generators
*.js;signalr-*-javadoc.jar; Exclude JavaScript files in the generated javadocs
*.binlog; Exclude msbuild log files
*.symbols.nupkg; Exclude NuGet symbols packages. These are not shipped to customers and should not be code signed.
*.binlog;; Exclude msbuild log files
*;*.symbols.nupkg; Exclude NuGet symbols packages. These are not shipped to customers and should not be code signed.
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"version": "3.0.100-preview-009750"
},
"msbuild-sdks": {
"Internal.AspNetCore.Sdk": "3.0.0-build-20190122.3"
"Internal.AspNetCore.Sdk": "3.0.0-build-20190123.3"
}
}
4 changes: 2 additions & 2 deletions korebuild-lock.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version:3.0.0-build-20190122.3
commithash:43e5fa8e3d8b192e573c3c14ae39b43e1d05cd5e
version:3.0.0-build-20190123.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ick. Is there any way to propagate this version from a single source of truth (preferably this file)? Annoying to need to change multiple locations.

Or, please point me to the script which does the needful 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually do this:

rm korebuild-lock.txt
build.cmd /t:Noop

That re-generates korebuild-lock.txt and global.json. Then, I manually update eng/Versions.props to match. The version in eng/Versions.props is only there to make Visual Studio happy. Command-line builds are always in-sync with the version in korebuild-lock.txt.

We could get rid of eng/Versions.props by replacing the PackageReference to Internal.AspNetCore.Sdk with a proper 'MSBuild Sdk', but that's not something I want to tackle just yet.

commithash:bfcdf8474c79320b7e5edcdb33d94bbdccb41e32