-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Backport SSR fix #8174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport SSR fix #8174
Conversation
/azp run AspNetCore-ci |
No pipelines are associated with this pull request. |
Approved for 2.2.4 |
@BrennanConroy We expect the branches to open sometime this week. I believe check-ins are due on next Tuesday (3/12). |
Would love to start using this, any information as to when/where to expect it? Minor bump to |
@pheuter You can expect this as a patch bump to @aspnet/signalr npm package, in April. |
@muratg Thanks, I'm assuming no major red flags with using |
@pheuter I recommend using the latest version (1.1.2 or 1.0.3) due to fixes that already went in. |
@muratg Well I can't use 1.1.2 because of this SSR issue, I guess I'll use 1.0.3 then. Thanks. |
@BrennanConroy you should update eng/PatchConfig.props. This fix won't ship without that. |
Backport of #8047
Fixes #7823
Description
The SignalR Typescript/javascript client was not able to run in Server Side Rendering apps. This fixes the client to be able to run in such environments.
Customer Impact
Customers will be able to use Server Side Rendering with SignalR when it would fail before.
Regression?
None, this scenario most likely never worked.
Risk
Low, our automated testing runs the known supported scenarios so they wont be broken. This is fixing a scenario we weren't aware of but should work.
@muratg