Skip to content

Backport SSR fix #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Backport SSR fix #8174

merged 1 commit into from
Mar 8, 2019

Conversation

BrennanConroy
Copy link
Member

Backport of #8047
Fixes #7823

Description

The SignalR Typescript/javascript client was not able to run in Server Side Rendering apps. This fixes the client to be able to run in such environments.

Customer Impact

Customers will be able to use Server Side Rendering with SignalR when it would fail before.

Regression?

None, this scenario most likely never worked.

Risk

Low, our automated testing runs the known supported scenarios so they wont be broken. This is fixing a scenario we weren't aware of but should work.

@muratg

@BrennanConroy BrennanConroy added the Servicing-consider Shiproom approval is required for the issue label Mar 4, 2019
@BrennanConroy BrennanConroy added this to the 2.2.x milestone Mar 4, 2019
@analogrelay
Copy link
Contributor

/azp run AspNetCore-ci
/azp run AspNetCore-pr-validation-temp

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@Eilon Eilon added the area-signalr Includes: SignalR clients and servers label Mar 5, 2019
@vivmishra vivmishra added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Mar 5, 2019
@vivmishra vivmishra modified the milestones: 2.2.x, 2.2.4 Mar 5, 2019
@vivmishra
Copy link

Approved for 2.2.4
Wait for branch to open.

@muratg
Copy link
Contributor

muratg commented Mar 5, 2019

@BrennanConroy We expect the branches to open sometime this week. I believe check-ins are due on next Tuesday (3/12).

@BrennanConroy
Copy link
Member Author

@muratg or @Eilon Merge please?

@Eilon Eilon merged commit aef62d9 into release/2.2 Mar 8, 2019
@Eilon Eilon deleted the brecon/ssr branch March 8, 2019 18:00
@pheuter
Copy link

pheuter commented Mar 8, 2019

Would love to start using this, any information as to when/where to expect it? Minor bump to @aspnet/signalr npm package? next tag?

@muratg
Copy link
Contributor

muratg commented Mar 8, 2019

@pheuter You can expect this as a patch bump to @aspnet/signalr npm package, in April.

@pheuter
Copy link

pheuter commented Mar 8, 2019

@muratg Thanks, I'm assuming no major red flags with using 1.0.0 for now?

@muratg
Copy link
Contributor

muratg commented Mar 8, 2019

@pheuter I recommend using the latest version (1.1.2 or 1.0.3) due to fixes that already went in.

@pheuter
Copy link

pheuter commented Mar 8, 2019

@muratg Well I can't use 1.1.2 because of this SSR issue, I guess I'll use 1.0.3 then. Thanks.

@dougbu
Copy link
Contributor

dougbu commented Mar 14, 2019

@BrennanConroy you should update eng/PatchConfig.props. This fix won't ship without that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants