Skip to content

Always load NodeHttpClient to fix SSR #8047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2019
Merged

Always load NodeHttpClient to fix SSR #8047

merged 2 commits into from
Mar 4, 2019

Conversation

BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Feb 28, 2019
BrennanConroy
BrennanConroy commented Feb 28, 2019
View reviewed changes
src/SignalR/clients/ts/webpack.config.base.js Outdated
@@ -40,7 +40,10 @@ module.exports = function (modulePath, browserBaseName, options) {
},
resolve: {
extensions: [".ts", ".js"],
alias: options.alias,
alias: {
"./NodeHttpClient": path.resolve(__dirname, "signalr/src/empty.ts"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: This saves 3kb for the browser .js files
We could just remove this and not save the bytes if we want

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right amount of clever 👍

Of course, I'd like a more first-class way to do this so we wouldn't even have to to waste bytes on a not-implemented NodeHttpClient, but this is certainly better than bundling the real thing in the browser dist.

muratg
muratg reviewed Feb 28, 2019
View reviewed changes
muratg
muratg approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will you be sending a PR patch as well? (2.2)

halter73
halter73 reviewed Feb 28, 2019
View reviewed changes
halter73
halter73 reviewed Feb 28, 2019
View reviewed changes
@analogrelay
Copy link
Contributor

@BrennanConroy reeeeeeeemixbase

@BrennanConroy BrennanConroy merged commit 508256d into master Mar 4, 2019
@BrennanConroy BrennanConroy deleted the brecon/node branch March 4, 2019 17:26
@BrennanConroy BrennanConroy mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@muratg muratg muratg approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@mikaelm12 mikaelm12 Awaiting requested review from mikaelm12

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BrennanConroy @analogrelay @halter73 @muratg