Skip to content

Use WORKITEM_ROOT instead of CORRELATIONPAYLOAD for helix workloads #9187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Apr 9, 2019

Better way of fixing #9186, but not certain it will work yet. CORRELATION_PAYLOAD is readonly on these new helix payloads.

@jkotalik jkotalik requested a review from dougbu as a code owner April 9, 2019 00:00
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helix build succeeded -- as did the main AzDO pipeline. So, this looks good.

But why are there no test results in the Helix run? That seems pretty major though it's not a new problem. See if there's a bug tracking that gap or create one please @jkotalik.

/cc @HaoK?

@HaoK
Copy link
Member

HaoK commented Apr 9, 2019

Maybe still need to update a few other env variables like DOTNET_CLI_HOME="$HELIX_CORRELATION_PAYLOAD/home"

Looks like its still trying to write to the read only directory

System.IO.IOException: Read-only file system
   at System.IO.FileSystem.CreateDirectory(String fullPath)
   at System.IO.Directory.CreateDirectory(String path)
   at Microsoft.Extensions.EnvironmentAbstractions.DirectoryWrapper.CreateDirectory(String path)
   at Microsoft.DotNet.Configurer.FirstTimeUseNoticeSentinel.CreateIfNotExists()
   at Microsoft.DotNet.Configurer.DotnetFirstTimeUseConfigurer.Configure()
   at Microsoft.DotNet.Cli.Program.ConfigureDotNetForFirstTimeUse(IFirstTimeUseNoticeSentinel firstTimeUseNoticeSentinel, IAspNetCertificateSentinel aspNetCertificateSentinel, IFileSentinel toolPathSentinel, Boolean hasSuperUserAccess, DotnetFirstRunConfiguration dotnetFirstRunConfiguration, IEnvironmentProvider environmentProvider)
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient)
   at Microsoft.DotNet.Cli.Program.Main(String[] args)
Running non-flaky tests.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 9, 2019
@jkotalik jkotalik force-pushed the jkotalik/cleanupInstallScript branch from 6dee31c to 8099cee Compare April 9, 2019 16:07
@jkotalik
Copy link
Contributor Author

jkotalik commented Apr 9, 2019

Receiving some bad image pulls (https://github.com/dotnet/core-eng/issues/5883).

@jkotalik jkotalik added the blocked The work on this issue is blocked due to some dependency label Apr 9, 2019
@jkotalik jkotalik closed this Apr 18, 2019
@jkotalik jkotalik reopened this Apr 18, 2019
@jkotalik jkotalik mentioned this pull request Apr 18, 2019
@analogrelay analogrelay added this to the 3.0.0-preview6 milestone Apr 18, 2019
@jkotalik jkotalik closed this Apr 19, 2019
@jkotalik jkotalik reopened this Apr 19, 2019
@jkotalik
Copy link
Contributor Author

Minus the IISExpress failures, this PR is working.

@jkotalik jkotalik closed this Apr 19, 2019
@jkotalik jkotalik reopened this Apr 19, 2019
@jkotalik jkotalik closed this Apr 23, 2019
@dougbu dougbu deleted the jkotalik/cleanupInstallScript branch May 18, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework blocked The work on this issue is blocked due to some dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants