-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix flaky routing test #9505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky routing test #9505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're exactly right about why.
Ouch, test failure I got here doesn't look good. Looks the same as https://github.com/aspnet/AspNetCore-Internal/issues/2224. I miss labeled that issue.
|
Environment.NewLine + | ||
"test: /0" + | ||
Environment.NewLine + | ||
"test: /1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI there's also an extra parameter you can pass that specifies whether to ignore newlin differences. I'm not sure how this got missed by the CI when I wrote the test, but #YOLO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't get missed, is that helix isn't in your face about failures. I'll be changing that shortly with #9187.
Bunch of helix tests failing due to newlines not matching https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190417.64/workItem/Microsoft.AspNetCore.Routing.Tests-netcoreapp3.0/wilogs.
I think this is because on helix, we build the dlls on windows and then test on linux, so \r\n gets compiled in.