Skip to content

Fix flaky routing test #9505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix flaky routing test #9505

merged 1 commit into from
Apr 18, 2019

Conversation

jkotalik
Copy link
Contributor

Bunch of helix tests failing due to newlines not matching https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190417.64/workItem/Microsoft.AspNetCore.Routing.Tests-netcoreapp3.0/wilogs.

I think this is because on helix, we build the dlls on windows and then test on linux, so \r\n gets compiled in.

@jkotalik jkotalik requested review from JamesNK and rynowak April 18, 2019 16:19
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 18, 2019
Copy link
Contributor

@analogrelay analogrelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're exactly right about why.

@jkotalik
Copy link
Contributor Author

Ouch, test failure I got here doesn't look good. Looks the same as https://github.com/aspnet/AspNetCore-Internal/issues/2224. I miss labeled that issue.

  
  Starting test group: Kestrel.Core.Tests/netcoreapp3.0
  Microsoft (R) Test Execution Command Line Tool Version 16.0.1
  Copyright (c) Microsoft Corporation.  All rights reserved.
  
  Starting test execution, please wait...
  [xUnit.net 00:00:00.62] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HPackEncoderTests.EncodesHeadersInSinglePayloadWhenSpaceAvailable'; falling back to single test case.
  [xUnit.net 00:00:00.63] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http1ConnectionTests.ConfiguringIHttpMinRequestBodyDataRateFeatureSetsMinRequestBodyDataRate'; falling back to single test case.
  [xUnit.net 00:00:00.63] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.Http1ConnectionTests.ConfiguringIHttpMinResponseDataRateFeatureSetsMinResponseDataRate'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.ValueReuseOnlyWhenAllowed'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.ValueReuseChangedValuesOverwrite'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.ValueReuseMissingValuesClear'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.ValueReuseNeverWhenNotAscii'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.ValueReuseLatin1NotConfusedForUtf16AndStillRejected'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.ValueReuseEmptyAfterReset'; falling back to single test case.
  [xUnit.net 00:00:00.71] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.HttpRequestHeadersTests.MultiValueReuseEmptyAfterReset'; falling back to single test case.
  [xUnit.net 00:00:00.74] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.KestrelServerLimitsTests.KeepAliveTimeoutValid'; falling back to single test case.
  [xUnit.net 00:00:00.74] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.KestrelServerLimitsTests.KeepAliveTimeoutInvalid'; falling back to single test case.
  [xUnit.net 00:00:00.74] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.KestrelServerLimitsTests.RequestHeadersTimeoutValid'; falling back to single test case.
  [xUnit.net 00:00:00.74] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.KestrelServerLimitsTests.RequestHeadersTimeoutInvalid'; falling back to single test case.
  [xUnit.net 00:00:00.75] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.MinDataRateTests.GracePeriodValid'; falling back to single test case.
  [xUnit.net 00:00:00.75] Microsoft.AspNetCore.Server.Kestrel.Core.Tests: Non-serializable data ('System.Object[]') found for 'Microsoft.AspNetCore.Server.Kestrel.Core.Tests.MinDataRateTests.GracePeriodInvalid'; falling back to single test case.
  The active test run was aborted. Reason: Unhandled Exception: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
     at System.Buffers.MemoryPoolBlock..ctor(SlabMemoryPool pool, MemoryPoolSlab slab, Int32 offset, Int32 length) in /_/src/Shared/Buffers.MemoryPool/MemoryPoolBlock.cs:line 20
     at System.Buffers.MemoryPoolBlock.Finalize() in /_/src/Shared/Buffers.MemoryPool/MemoryPoolBlock.cs:line 48
  
  Results File: F:\workspace\_work\1\s\artifacts\logs\Kestrel.Core.Tests-netcoreapp3.0-20190418.6_2019-04-18_16-56-56-715.trx
  
  Total tests: Unknown. Passed: 3524. Failed: 0. Skipped: 0.
  Test Run Aborted.
  Test execution time: 8.0209 Seconds
F:\workspace\_work\1\s\.dotnet\buildtools\kore

Environment.NewLine +
"test: /0" +
Environment.NewLine +
"test: /1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there's also an extra parameter you can pass that specifies whether to ignore newlin differences. I'm not sure how this got missed by the CI when I wrote the test, but #YOLO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't get missed, is that helix isn't in your face about failures. I'll be changing that shortly with #9187.

@jkotalik jkotalik merged commit eb41de8 into master Apr 18, 2019
@jkotalik jkotalik deleted the jkotalik/fixRoutingTest branch April 18, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants