Skip to content

Improve HostFiltering #9359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2019
Merged

Improve HostFiltering #9359

merged 6 commits into from
Jun 10, 2019

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Apr 14, 2019 •
edited
Loading

Is now included in DefaultBuilder and was showing up in traces

image

TryGetValueFast is addressed separately by #9341

Blocked by dotnet/extensions#1696

@benaadams benaadams mentioned this pull request Apr 14, 2019
Merged
@analogrelay analogrelay removed their request for review April 15, 2019 14:51
Tratcher
Tratcher reviewed Apr 15, 2019
View reviewed changes
@Tratcher
Copy link
Member

Hmm, that had some upstream side-effects. https://dev.azure.com/dnceng/public/_build/results?buildId=157194&view=ms.vss-test-web.build-test-results-tab

@analogrelay analogrelay added this to the 3.0.0-preview5 milestone Apr 17, 2019
@analogrelay
Copy link
Contributor

Moving to preview 6. Please do not merge until master is open for preview 6 changes. We're locking down preview 5 early due to a tight bit of release scheduling ;)

@benaadams
Copy link
Member Author

@Tratcher upstream fixes 20dd7e4

@benaadams
Copy link
Member Author

Rebased

Tratcher
Tratcher reviewed May 9, 2019
View reviewed changes
@benaadams
Copy link
Member Author

Won't pass until dotnet/extensions#1696 is merged, due to the current behaviour of StringValues

@benaadams
Copy link
Member Author

Pre
image

Post
image

@Tratcher
Copy link
Member

Tratcher commented Jun 4, 2019

Ready to rebase on dotnet/extensions#1696?

@benaadams
Copy link
Member Author

Rebased

jkotalik
jkotalik reviewed Jun 7, 2019
View reviewed changes
jkotalik
jkotalik reviewed Jun 7, 2019
View reviewed changes
@Tratcher Tratcher self-assigned this Jun 7, 2019
@benaadams
Copy link
Member Author

Rebased

@benaadams benaadams mentioned this pull request Jun 10, 2019
Closed
@benaadams
Copy link
Member Author

Raised issue for Helix issue #11038

@Tratcher Tratcher merged commit 37e6ad7 into dotnet:master Jun 10, 2019
@benaadams benaadams deleted the host-filter branch June 10, 2019 17:20
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@jkotalik jkotalik jkotalik approved these changes

Assignees

@Tratcher Tratcher

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.
6 participants
@benaadams @Tratcher @analogrelay @jkotalik @natemcmaster @amcasey