Skip to content

Added reference in Linq documentation from Xyz to XyzBy #10134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Added reference in Linq documentation from Xyz to XyzBy #10134

merged 1 commit into from
Jul 23, 2024

Conversation

EikeSchwass
Copy link
Contributor

Summary

Added reference in Linq documentation from Xyz to XyzBy (e.g. Union to UnionBy)

Fixes #10133

@EikeSchwass EikeSchwass requested a review from a team as a code owner July 22, 2024 10:21
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 22, 2024
@ghost ghost added the area-System.Linq label Jul 22, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-linq

Copy link

Learn Build status updates of commit 12b6758:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Linq/Enumerable.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@BillWagner BillWagner requested a review from gewarren July 23, 2024 13:40
@BillWagner
Copy link
Member

@gewarren This looks fine, but I wanted you to take a look before it's merged.

@EikeSchwass
Copy link
Contributor Author

@BillWagner is there a way for me to preview the changes? I did find a preview link in the build overview, but don't have permissions to view it.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. It's better to use <seealso> when linking to another API. I left a suggestion whose pattern you could apply to all the links you added.

Copy link

Learn Build status updates of commit 80a68c9:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Linq/Enumerable.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren
Copy link
Contributor

Thank you @EikeSchwass! The custom link text part isn't working unfortunately, and I've logged a bug for that.

@gewarren gewarren merged commit a9d87cd into dotnet:main Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Linq community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for Enumerable.Distinct, Except, Intersect, Max, Min, Order, OrderDescending, Union should reference <name>By alternative
3 participants