-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CI Update - Introduce "package-provided" monikers #10646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=473983&view=results source_repo.branch:pp-monikers source_repo.url:https://apidrop.visualstudio.com/_git/binaries
This comment was marked as outdated.
This comment was marked as outdated.
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=474713&view=results source_repo.branch:pp-monikers source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Learn Build status updates of commit ad0bd38:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have diligently reviewed all 3,350 files*
*I might have skipped a few. Like about 3,349.
THANK YOU SO MUCH, this is huge for those of us still targeting .NET Standard 2.0. |
It's an unfortunate side effect, yes, because it only searches within the selected moniker. Also if you go to the System.Net.Http namespace page for each moniker, it only shows the types that are in that moniker, not the entire namespace:
@nickwalkmsft @mtrilbybassett @huangmin-ms Any suggestions on how we could provide a better experience here? Would it be possible to combine, say, the .NET 8 and .NET 8 (package-provided) monikers into a single namespace page? |
This is awesome. cc @ericstj @ViktorHofer |
Fixes #10012
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=473983&view=results
source_repo.branch:pp-monikers
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Summary
Preview
Will be very hard to actually look at the diffs. Might have to make do with just looking at the previews.
FrozenDictionary<TKey,TValue> Class (System.Collections.Frozen) | Microsoft Learn