Skip to content

Add note about other types #10651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Add note about other types #10651

merged 2 commits into from
Feb 24, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 7, 2024

Related to #10646 (comment).

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 7, 2024
@ghost
Copy link

ghost commented Nov 7, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
@ghost
Copy link

ghost commented Nov 7, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

This comment was marked as outdated.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl

Copy link

Learn Build status updates of commit 979974b:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Net.Http.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren marked this pull request as ready for review November 7, 2024 19:26
@gewarren gewarren requested a review from a team as a code owner November 7, 2024 19:26
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren gewarren merged commit ea499fa into dotnet:main Feb 24, 2025
4 checks passed
@gewarren gewarren deleted the namespace-test branch February 24, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants